712262 - Port configure.in parts for android to NSPR

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Mike Hommey [:glandium]]

There are a number of changes in the way we setup android bits in mozilla/configure.in that haven't made it to NSPR but should.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add support for --with-android-version to NSPR. Enable dladdr if android version >= 8

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add support for --with-android-version to NSPR. Enable dladdr if android version >= 8

Actually, I'll address the dladdr issue separately, because I want to be able to use it even if it's known not to be defined in system headers.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Add support for --with-android-version to NSPR

Better with a construct that actually works in nspr

Comment 4

[Wan-Teh Chang]

Comment on attachment 583125 [details] [diff] [review]
Add support for --with-android-version to NSPR

r=wtc.

>-        android_platform="$android_ndk"/build/platforms/android-5/arch-arm
>+        android_platform="$android_ndk"/build/platforms/android-"$android_version"/arch-"$target_cpu"

The $android_version and $target_cpu variables don't need to be
quoted, right?  They can't contain spaces.

Alternatively, we need to quote $android_platform in the following:

    CPPFLAGS="-I$android_platform/usr/include $CPPFLAGS"
    CFLAGS="-mandroid -I$android_platform/usr/include -msoft-float -fno-short-enums -fno-exceptions $CFLAGS"
    CXXFLAGS="-mandroid -I$android_platform/usr/include -msoft-float -fpic -fno-short-enums -fno-exceptions $CXXFLAGS"
    LDFLAGS="-mandroid -L$android_platform/usr/lib -Wl,-rpath-link=$android_platform/usr/lib --sysroot=$android_platform $LDFLAGS"

I checked in the patch on the NSPR trunk (NSPR 4.9).  I also aligned
the various --with-android-xxx options in the help message.

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.318; previous revision: 1.317
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.320; previous revision: 1.319
done

Comment 5

[Wan-Teh Chang]

Attachment: Add support for --with-android-version to NSPR, v2

This is the patch I checked in.