Closed Bug 712296 Opened 12 years ago Closed 12 years ago

IOException on startup due to ZipFile closing before ZipInputStream read in AboutHomeContent

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 fixed, firefox12 fixed)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: kats, Assigned: blassey)

Details

Attachments

(1 file)

patch
5.30 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Running a build with some unrelated local changes on top of f3c943d2e763, saw this in the logcat on starting up a fresh uninstall/reinstall of Fennec.

I/GeckoAboutHome(28665): error reading json file
I/GeckoAboutHome(28665): java.io.IOException: Bad file number
I/GeckoAboutHome(28665): 	at java.util.zip.Inflater.setFileInputImpl(Native Method)
I/GeckoAboutHome(28665): 	at java.util.zip.Inflater.setFileInput(Inflater.java:316)
I/GeckoAboutHome(28665): 	at java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:202)
I/GeckoAboutHome(28665): 	at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:159)
I/GeckoAboutHome(28665): 	at java.util.zip.ZipFile$ZipInflaterInputStream.read(ZipFile.java:458)
I/GeckoAboutHome(28665): 	at org.mozilla.gecko.AboutHomeContent$7.run(AboutHomeContent.java:270)
I/GeckoAboutHome(28665): 	at android.os.Handler.handleCallback(Handler.java:587)
I/GeckoAboutHome(28665): 	at android.os.Handler.dispatchMessage(Handler.java:92)
I/GeckoAboutHome(28665): 	at android.os.Looper.loop(Looper.java:132)
I/GeckoAboutHome(28665): 	at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:154)
Attached patch patch — — Splinter Review 
one other thing to note, I'm not seeing a recommended-addons.json file in my profile on my galaxy nexus. Did something change such that we're not producing it anymore?
Assignee: nobody → blassey.bugs
Attachment #583164 - Flags: review?(mark.finkle)
Comment on attachment 583164 [details] [diff] [review]
patch

looks ok to me
Attachment #583164 - Flags: review?(mark.finkle) → review+
Whiteboard: [inbound] → [inbound][fennec-aurora]
https://hg.mozilla.org/mozilla-central/rev/abd7fa8acad2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Samsung Nexus S (Android 4.0.3)
20111221041234
http://hg.mozilla.org/mozilla-central/rev/d6b976e83811
Status: RESOLVED → VERIFIED
Comment on attachment 583164 [details] [diff] [review]
patch

[Approval Request Comment]
Fixes an exception
Attachment #583164 - Flags: approval-mozilla-aurora?
status-firefox11: --- → affected
status-firefox12: --- → fixed
Whiteboard: [inbound][fennec-aurora]
Comment on attachment 583164 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #583164 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.