712296 - IOException on startup due to ZipFile closing before ZipInputStream read in AboutHomeContent

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Running a build with some unrelated local changes on top of f3c943d2e763, saw this in the logcat on starting up a fresh uninstall/reinstall of Fennec.

I/GeckoAboutHome(28665): error reading json file
I/GeckoAboutHome(28665): java.io.IOException: Bad file number
I/GeckoAboutHome(28665): 	at java.util.zip.Inflater.setFileInputImpl(Native Method)
I/GeckoAboutHome(28665): 	at java.util.zip.Inflater.setFileInput(Inflater.java:316)
I/GeckoAboutHome(28665): 	at java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:202)
I/GeckoAboutHome(28665): 	at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:159)
I/GeckoAboutHome(28665): 	at java.util.zip.ZipFile$ZipInflaterInputStream.read(ZipFile.java:458)
I/GeckoAboutHome(28665): 	at org.mozilla.gecko.AboutHomeContent$7.run(AboutHomeContent.java:270)
I/GeckoAboutHome(28665): 	at android.os.Handler.handleCallback(Handler.java:587)
I/GeckoAboutHome(28665): 	at android.os.Handler.dispatchMessage(Handler.java:92)
I/GeckoAboutHome(28665): 	at android.os.Looper.loop(Looper.java:132)
I/GeckoAboutHome(28665): 	at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:154)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

one other thing to note, I'm not seeing a recommended-addons.json file in my profile on my galaxy nexus. Did something change such that we're not producing it anymore?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583164 [details] [diff] [review]
patch

looks ok to me

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/abd7fa8acad2

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/abd7fa8acad2

Comment 5

[Aaron Train [:aaronmt]]

Samsung Nexus S (Android 4.0.3)
20111221041234
http://hg.mozilla.org/mozilla-central/rev/d6b976e83811

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583164 [details] [diff] [review]
patch

[Approval Request Comment]
Fixes an exception

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 583164 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/177eddd8f816