712307 - [ICS] - Can't see the address bar magnifying glass

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (12/20) - about:home

See screenshot.

--
Samsung Nexus S (Android 4.0.3)
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111220 Firefox/11.0a1 Fennec/11.0a1

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian or Patryk: Can we get some new assets for this?

Comment 3

[Ian Barlow (:ibarlow)]

I think these have already been updated... at least i see a new magnifying glass in Aurora. 

We'll be making them even darker still, though, in bug 715255

Comment 4

[Ian Barlow (:ibarlow)]

oh oops. That was made a dupe. I'll add newer, even darker assets here soon.

Comment 5

[Ian Barlow (:ibarlow)]

Attachment: icon assets

These include Search, Go and Stop so if we could please replace all of them at the same time, thanks.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian - This bug is "ICS" but I think we want these images for Honeycomb too. Can you confirm?

Comment 7

[Ian Barlow (:ibarlow)]

Ah yes, thanks. These icons should actually be replaced across the board. I included assets for all sizes across ICS / HC / GB / Froyo in the attachment there

Comment 8

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Per comment 7, this patch uses the same images across all Android OS versions, so we no longer override the MDPI/HDPI versions for v11+.

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 587786 [details] [diff] [review]
patch

LGTM.

Comment 10

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5536ad3e639

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 587786 [details] [diff] [review]
patch

[Approval Request Comment]
Image-only, Android-only patch that fixes some unreadable icons in the main UI on some versions of Android, and generally makes the UI more consistent.

Comment 12

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c5536ad3e639

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 587786 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 14

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e10105bf78f3

Comment 15

[Aaron Train [:aaronmt]]

Verified on M-A & M-C
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a

20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623