71234 - Open Web Location dialog from Editor does not load page(iff http:// is left off address)

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, defect, P2)

Description

[shrirang khanzode]

seen on linux, windows trunk 0307. could not find a dup..sorry

steps:
Launch composer
Select File|Open Web Location (on liux, type something in the blank window 
before opening this menu)

Type "www.yahoo.com" in the url and select "New Composer window"
Click OK...
Observe that nothing happens 

console shows the following error.

javascript error:
chrome://communicator/content/openLocation.j line 88 : browser.getShortcutOrURI 
is not a function

Comment 1

[Blake Ross]

Taking.

Comment 2

[Charles Manske]

Blake: Any progress on this bug?
I don't get the use of the "browser" object in that code. Why can't we put
all JS needed for loading URLs in a logical global JS file that we all included?

Comment 3

[rubydoo123]

*** Bug 71690 has been marked as a duplicate of this bug. ***

Comment 4

[Charles Manske]

Attachment: Interim suggested fix to get loading URL to work in Composer, but no support for shortcuts

Comment 5

[chris hofmann]

got reviews?   ready to check in today?

Comment 6

[Blake Ross]

We'll investigate better ways of fixing this later, let's get this into .8.1. 
Thanks Charley. r=blake

Comment 7

[Christopher Blizzard (:blizzard)]

r=blizzard

Comment 8

[Asa Dotzler [:asa]]

a=asa on behalf of drivers.  Can someone this checked in soon.  Not sure if
blake is available this morning.

Comment 9

[Blake Ross]

Workaround checked in.  Pushing off to .9 to investigate better fix.

(cc'ing Charley, which I forgot to do earlier).

Comment 10

[Charles Manske]

Blake: The "workaround" was NOT checked in!
I still have that fix in my tree and didn't notice it, but others are getting
angry!
I'll check it in today if you want.

Comment 11

[Blake Ross]

The workaround was checked into 0.8.1.  I didn't see a point in checking it 
into the tip since we'll find a better fix for 0.9, and this doesn't seem like 
critical functionality, but feel free to check it in to the tip if you want...

Comment 12

[Charles Manske]

Not critical? It drives anyone using Composer crazy!

Comment 13

[Kathleen :Brade]

I can't believe that .9 isn't going to have this fixed! argh!
We need to put this in the release notes.  :-(

Comment 14

[Kathleen :Brade]

*** Bug 76692 has been marked as a duplicate of this bug. ***

Comment 15

[Charles Manske]

I agree with Kathy. This is not acceptable. We must checkin the suggested
"interim" fix for 0.9.

Comment 16

[Blake Ross]

Cc'ing Asa to a=

Comment 17

[Asa Dotzler [:asa]]

a=[e-mail] for checking in interim fix again :)

Comment 18

[Simon Fraser [no longer active]]

Why has this still not been checked in?

Comment 19

[sujay]

can we get some kind of status on this? thanks!

Comment 20

[Charles Manske]

The "interim suggested fix" was checked in, so loading a URL works, but not
the custom keywords when opening into Composer.

Comment 21

[sairuh (rarely reading bugmail)]

i cannot open a url in a composer window via the Open Web Location dialog [at
least when launched from the browser --using 2001.05.08.0x bits]. kin, charley
said that you're working on this, yes?

Comment 22

[sairuh (rarely reading bugmail)]

oops, i was unclear [and prolly not quite understanding this bug]... kin, i was
wondering if there is yet another bug filed covering my last comment --or if
this is still the right place? thx again.

Comment 23

[Kathleen :Brade]

Sairuh--I'm not sure about the .9.1 branch but we need to get this in the
release notes if it isn't working.  

Please file a new bug. This bug isn't getting enough traction and this is a
major regression for Composer.  Composer could live without custom keywords but
we need a way to open a url in Composer.  Please cc Charley, Kin, me and anyone
else who wants to track that bug ([e-mail]?)

Comment 24

[sairuh (rarely reading bugmail)]

i filed bug 84191 to cover the Open Web Location issue.

Comment 25

[Charles Manske]

We will be removing the 'Paste As' menuitem (see bug 41547), so this conflict
will go away then.

Comment 26

[Charles Manske]

Damn, wrong bug! Ignore my last comment.

Comment 27

[Jaime Rodriguez, Jr.]

Adding nsbeta1 keyword to all regressions so they *get some love* and attention.

Comment 28

[Syd Logan]

marking WORKSFORME, nsbeta1-

Comment 29

[shrirang khanzode]

does not wfm. I still see a blank page instead of the url loading in composer 
(winNT 0228 trunk)

Comment 30

[shrirang khanzode]

well..i was talking about the original problem I reported this bug for...

Comment 31

[sujay]

Its also not working for me using 3/1 trunk build on Windows..

simplifying summary and REOPEN.

nsbeta1+

Comment 32

[sujay]

repeating original steps:

1) launch netscape
2) launch composer
3) File | Open Web Location
4) enter a URL and pull down open in composer
5) click Open

no page loads.

Comment 33

[sujay]

removing plus. Syd or someone else can plus it.

Comment 34

[Peter Trudelle]

nsbeta1+ per Nav triage team, need to apply interim fix that shipped last time.
->1.0

Comment 35

[Blake Ross]

Um, the interim fix is still in. And this works fine for me. Can someone else test?

Comment 36

[shrirang khanzode]

no...
not on 0311 trunk on win for me. still cannot open a website(inside editor) 
using 'open web locn' dialog in editor !

Comment 37

[Peter Trudelle]

I thought interim fix only went on to shipping branch, not trunk.  ->1.2

Comment 38

[Kathleen :Brade]

remove nsbeta1- for reconsideration
I see this on my Mac mozilla build from yesterday (it did work for 6.2)
I do not see anything on the console.

Note: to reproduce you need to be in a Composer window before opening the "open
web location" dialog.

Comment 39

[Peter Trudelle]

nsbeta1- per Nav triage team

Comment 40

[sujay]

Ok I just retested this and the problem still exists if and only if
you enter an address w/o the "http://"  in front of the URL.

so if you enter "www.yahoo.com" nothing will load in composer
but if you do "http://www.yahoo.com" then it will load that page in composer.

Comment 41

[sujay]

re-assign to charley per syd

renominating nsbeta1 because most users leave off the "http://" when
entering addresses because they are accustomed to doing this in the
browser URL field. If its works there, it should work in the Open
Web Location dialog.

Comment 42

[sujay]

re-assign ---> blake per cmanske

Comment 43

[Charles Manske]

The real issue is what I said in comment #2: the "smart" interpretation of 
URL is done in browser-only code. It should be somewhere sharable with Composer.
If this is really important, we could do another hack to get the scheme, and if
it's missing assume "http://" and prepend that.

Comment 44

[Syd Logan]

Not really an EDITORBASE issue, not a basic editing issue. Adding relnote
keyword, we need this to be mentioned in the release notes at a minimum, UI to
indicate that the URL cannot be handled would be better, a hack in composer to
provide the leading http:// would be better still, fixing the real bug would be
ideal. But none of this is EDITORBASE really. Leaving the nsbeta1 for triage.

Comment 45

[Peter Trudelle]

nsbeta1-

Comment 46

[Blake Ross]

reassigning open web location dialog bugs to hewitt.

Comment 47

[Kathleen :Brade]

*** Bug 109941 has been marked as a duplicate of this bug. ***

Comment 48

[sujay]

*** Bug 135396 has been marked as a duplicate of this bug. ***

Comment 49

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 50

[Kathleen :Brade]

This is a Composer issue (if it is indeed still a bug); remove EDITORBASE- since
it's not a core issue

Comment 51

[sairuh (rarely reading bugmail)]

no longer a problem. w4m with 2003.06.03.07-1.4 build on linux rh8.0.