712422 - please add a --bootstrap cli flag to reftest/crashtest/jsreftest for android

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in order to run reftests on android, we need to use the --bootstrap flag.  This is not for android-xul, just for android.

Comment 1

[Mike Taylor [:bear]]

Attachment: buildbotcustom change

Comment 2

[Mike Taylor [:bear]]

Attachment: buildbot-configs change

Comment 3

[Mike Taylor [:bear]]

coop - I attached the two work-in-progress patches that I had

Comment 4

[Chris Cooper [:coop] (he/him)]

Aki: bear suggested I flag you for review on these patches...any problems with the approach?

bear: have these patches been through staging yet? "No" is fine, I just don't want to land without testing.

Comment 5

[Aki Sasaki (not active)]

(In reply to Chris Cooper [:coop] from comment #4)
> Aki: bear suggested I flag you for review on these patches...any problems
> with the approach?

A bit backed up atm.  Ping me if I let this review sit too long (thinking sometime tomorrow before EOD).

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 586223 [details] [diff] [review]
buildbot-configs change

.

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 586222 [details] [diff] [review]
buildbotcustom change

Nit: this would actually be cleaner if the factory.py portions were just

+                 options=self.remoteExtras.get('cmdOptions'),

since they'll default to None and there's an |if cmdOptions:| in RemoteReftestStep.

I'm wondering if the options are actually passed to the RemoteReftestStep from RemoteUnittestFactory (I think it isn't).  r-'ing for that, but I think this will work when that's done.  I'd also love to see this tested.

As a side note, I think the configs portion of these patches, if not the buildbotcustom portion, will bitrot bug 695351 or vice versa.

Comment 8

[Mike Taylor [:bear]]

taking this bug back from coop to implement aki's changes

Comment 9

[Mike Taylor [:bear]]

remoteExtras is definitely on the parameter list in generateTestBuild() (in misc.py line 385)

        factory = RemoteUnittestFactory(
            platform=platform,
            productName=productName,
            hostUtils=hostUtils,
            suites=suites,
            hgHost=config['hghost'],
            repoPath=config['repo_path'],
            buildToolsRepoPath=config['build_tools_repo_path'],
            branchName=branch_name,
            remoteExtras=pf.get('remote_extras'),
            downloadSymbols=pf.get('download_symbols', True),
        )

I'm making the change now and pushing the patch to my test master

Comment 10

[Mike Taylor [:bear]]

Attachment: buildbotcustom change

removed [] default for get() call and also double-checked that cmdOptions is in the parameter list for RemoteReftestStep (it is because it's being added by this patch)

tested yesterday on staging tegras

Comment 11

[Mike Taylor [:bear]]

Comment on attachment 588196 [details] [diff] [review]
buildbotcustom change

committed changeset 1994:b7d6fb59aba1

Comment 12

[Mike Taylor [:bear]]

Comment on attachment 586223 [details] [diff] [review]
buildbot-configs change

committed changeset 5290:af6628ebdea3

Comment 13

[Mike Taylor [:bear]]

landed in yesterdays reconfig

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

I looked on inbound at jobs from this morning and I don't see the --bootstrap flag.  Maybe this is on another branch or hasn't rolled out to the foopies yet?

Comment 15

[Mike Taylor [:bear]]

it was a change to the master so doesn't need to be rolled out to foopies...

let me paste here the header from some jobs so you can tell me if I messed something up:

Android Tegra 250 mozilla-inbound opt test crashtest-1

python reftest/remotereftest.py --deviceIP 10.250.49.13 --xre-path ../hostutils/xre --utility-path ../hostutils/bin --app org.mozilla.fennec --http-port 30026 --ssl-port 31026 --pidfile /builds/tegra-026/test/../remotereftest.pid --enable-privilege --bootstrap --total-chunks 2 --this-chunk 1 reftest/tests/testing/crashtest/crashtests.list --symbols-path=../symbols

Android Tegra 250 mozilla-inbound opt test jsreftest-3

python reftest/remotereftest.py --deviceIP 10.250.50.100 --xre-path ../hostutils/xre --utility-path ../hostutils/bin --app org.mozilla.fennec --http-port 30190 --ssl-port 31190 --pidfile /builds/tegra-190/test/../remotereftest.pid --enable-privilege --bootstrap --total-chunks 3 --this-chunk 3 --extra-profile-file=jsreftest/tests/user.js jsreftest/tests/jstests.list --symbols-path=../symbols

Android XUL Tegra 250 mozilla-inbound opt test crashtest-1

python reftest/remotereftest.py --deviceIP 10.250.49.6 --xre-path ../hostutils/xre --utility-path ../hostutils/bin --app org.mozilla.fennec --http-port 30019 --ssl-port 31019 --pidfile /builds/tegra-019/test/../remotereftest.pid --enable-privilege --total-chunks 2 --this-chunk 1 reftest/tests/testing/crashtest/crashtests.list --symbols-path=../symbols

Android XUL Tegra 250 mozilla-inbound opt test jsreftest-2

python reftest/remotereftest.py --deviceIP 10.250.49.3 --xre-path ../hostutils/xre --utility-path ../hostutils/bin --app org.mozilla.fennec --http-port 30016 --ssl-port 31016 --pidfile /builds/tegra-016/test/../remotereftest.pid --enable-privilege --total-chunks 3 --this-chunk 2 --extra-profile-file=jsreftest/tests/user.js jsreftest/tests/jstests.list --symbols-path=../symbols