Closed Bug 712506 Opened 8 years ago Closed 8 years ago
[Galaxy Nexus] Excess lines in favicon and reload button on XHDPI devices
on ICS, there's an extra horizontal line in the favicon and reload button. see screenshot. doesnt affect honeycomb or gingerbread see screenshot Repro: 1) install Firefox 9 on ICS device, Galaxy Nexus 2) verify a horizontal line in the UI Expected: - no horiz lines
It looks like this happens on any device with a >300dpi screen, like the Galaxy Nexus. It happens because the background images for the urlbar endcaps are not positioned correctly.
The gingerbread theme background images aren't big enough to cover the whole endcaps on XHDPI devices. This fixes it so they blend nicely with the background color when that happens. Also requesting approval to take this mobile-only CSS fix for Aurora 11 and Beta 10. This fixes an ugly UI glitch in the main XUL Fennec UI on some newer devices.
Comment on attachment 583354 [details] [diff] [review] patch r+, but I'd like to know why you are changing the colors?
Attachment #583354 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #3) > Comment on attachment 583354 [details] [diff] [review] > patch > > r+, but I'd like to know why you are changing the colors? The colors didn't match the images on gingerbread. (I think they were left over from the froyo theme.) On high-dpi devices where the background did not cover the whole endcap, the mismatch caused dark areas outside the image boundaries.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 583354 [details] [diff] [review] patch [triage comment] Approved for aurora and beta. UI polish, trivial patch, low risk / mobile-only. Please land as soon as possible
Verified fix on 10b2. Mozilla/5.0 (Android; Linux armv7l; rv:10.0 Gecko/2011011228 Firefox/10.0 Fennec/10.0
You need to log in before you can comment on or make changes to this bug.