712509 - [Skia] Skia code is linking against libstdc++ operator new on Android

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

On android, files within gfx/skia are linking against the libstdc++ allocation functions instead of going through mozalloc.

This is causing crashes when we allocate objects in gfx/2d, and skia attempts to free them (via unref()).

I've got a temporary workaround, moving all allocations into skia itself, but I'd rather figure out why this is and fix it properly.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Use standard malloc on skia

Instead of linking against stdlib new/free, this turned out be skia having wrappers around malloc/free that were allocating a block header to track allocations.

Allocating objects without this header, and then attempting to adjust for the header when free'ing was causing this issue.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 587595 [details] [diff] [review]
Use standard malloc on skia

Review of attachment 587595 [details] [diff] [review]:
-----------------------------------------------------------------

From what I understand this might lose us some debug capabilities of Skia so it's a shame. I'm fine with this though as allocation/freeing consistency within our code is important.

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/465e3ad31c64

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/465e3ad31c64