712518 - Improve MockFilePicker.jsm

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Geoff Lankow (:darktrojan)]

There's some things that could be improved about the MockFilePicker, namely:
* create separate methods for setup and cleanup
* unregister the class when finished
* use the result of showCallback, if there is one, instead of returnValue

Anything else?

Comment 1

[Geoff Lankow (:darktrojan)]

* adding the GPL/LGPL, whoops.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: patch

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 584147 [details] [diff] [review]
patch

Review of attachment 584147 [details] [diff] [review]:
-----------------------------------------------------------------

My only question is we are replacing reset() with init() at the beginning of most of the test cases.  With init() we assigned default values to variables.  Is that not needed now?

Comment 4

[Geoff Lankow (:darktrojan)]

(In reply to Joel Maher (:jmaher) from comment #3)
> My only question is we are replacing reset() with init() at the beginning of
> most of the test cases.  With init() we assigned default values to
> variables.  Is that not needed now?

ITYM "With reset() we ...".
They still get set, init() calls reset().

Comment 5

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e20ed47b03f2

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

oh, I overlooked that, that one line hidden in there:)

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/e20ed47b03f2