Last Comment Bug 712523 - IonMonkey: Fix getFrameInfo. (rounding error on Int)
: IonMonkey: Fix getFrameInfo. (rounding error on Int)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Nicolas B. Pierron [:nbp]
:
Mentors:
Depends on:
Blocks: IonMonkey
  Show dependency treegraph
 
Reported: 2011-12-20 18:05 PST by Nicolas B. Pierron [:nbp]
Modified: 2011-12-22 19:00 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix. (3.49 KB, patch)
2011-12-21 19:09 PST, Nicolas B. Pierron [:nbp]
dvander: review+
Details | Diff | Splinter Review

Description Nicolas B. Pierron [:nbp] 2011-12-20 18:05:03 PST
The current implementation is subject to rounding error and may be stuck in an infinite loop looking always at the same element.

One option is to always reduce the search space by removing the last guess from the search space.
Comment 1 Nicolas B. Pierron [:nbp] 2011-12-21 19:09:47 PST
Created attachment 583705 [details] [diff] [review]
Fix.
Comment 2 David Anderson [:dvander] 2011-12-21 19:46:41 PST
Comment on attachment 583705 [details] [diff] [review]
Fix.

Thanks, appears to fix my testcase.
Comment 3 Nicolas B. Pierron [:nbp] 2011-12-22 19:00:55 PST
https://hg.mozilla.org/projects/ionmonkey/rev/860845757cc8

Note You need to log in before you can comment on or make changes to this bug.