712526 - Tabs menu screen covers the entire screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Tony Chung [:tchung]]

Attachment: screenshot portrait

When greater than 5 tabs open, the new UX displays over the entire Screen, completely covering up Firefox.

See screenshots.  

REpro:
1) install 12-20-2011, 12.0a1 fennec nightly.  SGS2 and Galaxy Nexus
2) open > 5 tabs
3) click the tab drop marker to open the tabs
3) verify tab menu covers the entire viewport of the screen

Expected:
- not a full screen tab menu, with some space at the bottom

ActuaL:
- full screen view

Comment 1

[Tony Chung [:tchung]]

Attachment: screenshot landscape

Comment 2

[Aaron Train [:aaronmt]]

I think that works as intended. Just as long as you can scroll through the list and back out of the panel.

CC'ing :sriram, :ibarlow for clarification

Comment 3

[Ian Barlow (:ibarlow)]

Actually, we only want the tab menu to cover about 2/3 of the screen, so it doesn't feel like you're completely switching contexts when you open the tab menu

Comment 6

[Ian Barlow (:ibarlow)]

Just a friendly ping to try and keep this bug moving along - Devs, do you need any more information from UX to proceed?

Comment 7

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch restricts the height of the tabs menu.
It tries to set a height of 2/3 of the screen. If the list's visible height is a direct multiple of X number of list items, then an additional 1/3rd of the item is shown - to show a perception that there is more in the list. -- This is as per UX team's requirement.

Comment 8

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4df33078d5d0

Comment 9

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/4df33078d5d0

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Sriram, request approval for aurora

Comment 11

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 591160 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
The tabs menu will occupy the entire screen and the user will lose context of what he is doing. The UX team wants this to be available for release on high priority.

Testing completed (on m-c, etc.): Landed on m-c on 01/28

Risk to taking this patch (and alternatives if risky):
The risk is very low as it just alters the height of the tabs menu. There wouldn't be any crashes of any sort due to this.

Comment 12

[Paul Feher]

Verified on:
Nightly Fennec 13.0a1 (2012-03-05)
Device: HTC Desire Z
OS: Android 2.3.3