Closed Bug 71257 Opened 23 years ago Closed 22 years ago

split nsStyleUtil.cpp

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.2alpha

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Whiteboard: [patch])

Attachments

(2 files, 2 obsolete files)

I don't think nsStyleUtil.cpp needs to be in content/shared.  One function in
it, |FindNonTransparentBackground|,is used only in layout, and all the others
are used only in content.  So |FindNonTransparentBackground| should probably
find a new home, if necessary in its own file, but perhaps in nsLayoutUtils, and
the rest of nsStyleUtil should move back to content/html/style/src/ (although
it would be nice to move some of the style stuff that makes more sense in layout
back to layout, but that's a separate issue).
Severity: normal → minor
Keywords: helpwanted
Target Milestone: --- → Future
FindNonTransparentBackground should fit nicely in nsCSSRendering.
Taking bug.
Assignee: heikki → dbaron
Severity: minor → major
Priority: -- → P2
Target Milestone: Future → mozilla1.1beta
This blocks bug 154751 since I want to move ZoomFont to nsStyleUtil without
increasing code size.
Blocks: 154751
Keywords: helpwanted
Whiteboard: [patch]
Target Milestone: mozilla1.1beta → mozilla1.2alpha
Comment on attachment 90912 [details] [diff] [review]
proposed split patch

I think you missed changes in nsCSSRendering.h. Otherwise looks good.
Forgot to diff the right list of files.
Attachment #90912 - Attachment is obsolete: true
Comment on attachment 90970 [details] [diff] [review]
above, but including nsCSSRendering.h changes too

r=heikki
Attachment #90970 - Flags: review+
Comment on attachment 90970 [details] [diff] [review]
above, but including nsCSSRendering.h changes too

sr=bzbarsky, but could you change those |context != nsnull| chacks to just test
 |context|?
Attachment #90970 - Flags: superreview+
Comment on attachment 90970 [details] [diff] [review]
above, but including nsCSSRendering.h changes too

Fix checked in to trunk, 2002-08-11 10:56 PDT.

(Now I just need to move nsStyleUtil into content/html/style/.)
Attachment #90970 - Attachment is obsolete: true
These makefile changes assume nsStyleUtil.h moves from content/shared/public/
to content/html/style/public/ and nsStyleUtil.cpp moves from
content/shared/src/ to content/html/style/src/.
This reduces the number of files that include nsStyleUtil.h to the ones that
actually need it.  It also includes some include changes I've had to mathml
that have been lying around in my tree (making nsIMathMLFrame.h stand alone,
and reducing includes for many other files).
Comment on attachment 95278 [details] [diff] [review]
header include reduction

r=rbs

is it still necessary to retain this one?
 #include "nsIRenderingContext.h"
Attachment #95278 - Flags: review+
Comment on attachment 95276 [details] [diff] [review]
makefile changes for file move

sr=bzbarsky
Attachment #95276 - Flags: superreview+
Fixes checked in, 2002-08-16 04:52 / 15:56 / 16:00 / 16:57 PDT.

(I didn't want to deal with making additional #include cleanup changes.)
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: