71257 - split nsStyleUtil.cpp

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I don't think nsStyleUtil.cpp needs to be in content/shared.  One function in
it, |FindNonTransparentBackground|,is used only in layout, and all the others
are used only in content.  So |FindNonTransparentBackground| should probably
find a new home, if necessary in its own file, but perhaps in nsLayoutUtils, and
the rest of nsStyleUtil should move back to content/html/style/src/ (although
it would be nice to move some of the style stuff that makes more sense in layout
back to layout, but that's a separate issue).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FindNonTransparentBackground should fit nicely in nsCSSRendering.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking bug.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This blocks bug 154751 since I want to move ZoomFont to nsStyleUtil without
increasing code size.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: proposed split patch

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 90912 [details] [diff] [review]
proposed split patch

I think you missed changes in nsCSSRendering.h. Otherwise looks good.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: above, but including nsCSSRendering.h changes too

Forgot to diff the right list of files.

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 90970 [details] [diff] [review]
above, but including nsCSSRendering.h changes too

r=heikki

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 90970 [details] [diff] [review]
above, but including nsCSSRendering.h changes too

sr=bzbarsky, but could you change those |context != nsnull| chacks to just test
 |context|?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 90970 [details] [diff] [review]
above, but including nsCSSRendering.h changes too

Fix checked in to trunk, 2002-08-11 10:56 PDT.

(Now I just need to move nsStyleUtil into content/html/style/.)

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: makefile changes for file move

These makefile changes assume nsStyleUtil.h moves from content/shared/public/
to content/html/style/public/ and nsStyleUtil.cpp moves from
content/shared/src/ to content/html/style/src/.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: header include reduction

This reduces the number of files that include nsStyleUtil.h to the ones that
actually need it.  It also includes some include changes I've had to mathml
that have been lying around in my tree (making nsIMathMLFrame.h stand alone,
and reducing includes for many other files).

Comment 12

[rbs]

Comment on attachment 95278 [details] [diff] [review]
header include reduction

r=rbs

is it still necessary to retain this one?
 #include "nsIRenderingContext.h"

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 95276 [details] [diff] [review]
makefile changes for file move

sr=bzbarsky

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixes checked in, 2002-08-16 04:52 / 15:56 / 16:00 / 16:57 PDT.

(I didn't want to deal with making additional #include cleanup changes.)