The default bug view has changed. See this FAQ.

Better to use just <include> and avoid <merge>

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sriram, Assigned: sriram)

Tracking

unspecified
Firefox 12
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
On a sudden realization, I found that we are including something into another <custom.View> and creating a new file for this included content inside a <merge>.
Instead, we can have the <custom.View> as the parent element.
I'm not sure if this can provide a performance win, but the code looks more elegant.
(Assignee)

Comment 1

5 years ago
Created attachment 583421 [details] [diff] [review]
Patch

This patch remove 2 files in layout-v11/.
One of the files have been renamed for better naming convention.
A new file is added to separate the "awesomebar_search" related UI.
As expected, the code looks better and clearer (than having an "action_bar") file separately.
I haven't checked it against any performance win -- but we should have some for sure. :)
Assignee: nobody → sriram
Attachment #583421 - Flags: review?(mark.finkle)
Comment on attachment 583421 [details] [diff] [review]
Patch

Looks good to me. Getting Brad for a second opinion.
Attachment #583421 - Flags: review?(mark.finkle)
Attachment #583421 - Flags: review?(blassey.bugs)
Attachment #583421 - Flags: review+
Attachment #583421 - Flags: review?(blassey.bugs) → review+
Priority: -- → P4
https://hg.mozilla.org/integration/mozilla-inbound/rev/757a48403154
status-firefox11: --- → affected
status-firefox12: --- → affected
https://hg.mozilla.org/mozilla-central/rev/757a48403154
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 583421 [details] [diff] [review]
Patch

[Approval Request Comment]
Cleans up the code, Uses a better pattern. Blocking other changes from Aurora.
Attachment #583421 - Flags: approval-mozilla-aurora?
status-firefox12: affected → fixed

Comment 6

5 years ago
Comment on attachment 583421 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for aurora.
Attachment #583421 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/ac659ffd7c54
status-firefox11: affected → fixed
You need to log in before you can comment on or make changes to this bug.