Closed
Bug 712574
Opened 14 years ago
Closed 14 years ago
Better to use just <include> and avoid <merge>
Categories
(Firefox for Android Graveyard :: General, defect, P4)
Tracking
(firefox11 fixed, firefox12 fixed)
RESOLVED
FIXED
Firefox 12
People
(Reporter: sriram, Assigned: sriram)
Details
Attachments
(1 file)
15.91 KB,
patch
|
mfinkle
:
review+
blassey
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
On a sudden realization, I found that we are including something into another <custom.View> and creating a new file for this included content inside a <merge>.
Instead, we can have the <custom.View> as the parent element.
I'm not sure if this can provide a performance win, but the code looks more elegant.
Assignee | ||
Comment 1•14 years ago
|
||
This patch remove 2 files in layout-v11/.
One of the files have been renamed for better naming convention.
A new file is added to separate the "awesomebar_search" related UI.
As expected, the code looks better and clearer (than having an "action_bar") file separately.
I haven't checked it against any performance win -- but we should have some for sure. :)
Assignee: nobody → sriram
Attachment #583421 -
Flags: review?(mark.finkle)
Comment 2•14 years ago
|
||
Comment on attachment 583421 [details] [diff] [review]
Patch
Looks good to me. Getting Brad for a second opinion.
Attachment #583421 -
Flags: review?(mark.finkle)
Attachment #583421 -
Flags: review?(blassey.bugs)
Attachment #583421 -
Flags: review+
Updated•14 years ago
|
Attachment #583421 -
Flags: review?(blassey.bugs) → review+
Updated•14 years ago
|
Priority: -- → P4
Comment 3•14 years ago
|
||
status-firefox11:
--- → affected
status-firefox12:
--- → affected
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment 5•13 years ago
|
||
Comment on attachment 583421 [details] [diff] [review]
Patch
[Approval Request Comment]
Cleans up the code, Uses a better pattern. Blocking other changes from Aurora.
Attachment #583421 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Comment 6•13 years ago
|
||
Comment on attachment 583421 [details] [diff] [review]
Patch
[Triage Comment]
Mobile only - approved for aurora.
Attachment #583421 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•13 years ago
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•