712627 - Fennec crashes if a long tap is performed in AwesomeBar/History

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Cristian Nicolae (:xti)]

Attachment: crash log

Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20111220
Firefox/12.0a1 Fennec/12.0a1
Devices: Samsung Galaxy S
OS: Android 2.2

Steps to reproduce:
1. Open Fennec App
2. Tap on URL Bar
3. Tap on History Tab
4. Long tap on any page from History list

Expected result:
No crash should occur after step 4.

Actual result:
After step 4, the app crashes. Please see the attached log.

Note:
When the crash reporter is displayed, it just freezes. Cancel or Restart Fennec buttons cannot be tapped.

Comment 1

[Aaron Train [:aaronmt]]

Probably a regression from adding contextual menus to items in bug 708273

---

D/GeckoAwesomeBarTabs( 2043): Creating History tab
D/dalvikvm(  155): GC_CONCURRENT freed 841K, 12% free 13780K/15623K, paused 11ms+8ms
I/ActivityManager(  155): Displayed org.mozilla.fennec/org.mozilla.gecko.AwesomeBar: +209ms
I/GeckoApp( 2043): stop
E/GeckoApp( 2043): top level exception
E/GeckoApp( 2043): java.lang.ClassCastException: android.widget.ExpandableListView$ExpandableListContextMenuInfo cannot be cast to android.widget.AdapterView$AdapterContextMenuInfo
E/GeckoApp( 2043): 	at org.mozilla.gecko.AwesomeBar.onCreateContextMenu(AwesomeBar.java:388)
E/GeckoApp( 2043): 	at android.view.View.createContextMenu(View.java:6182)
E/GeckoApp( 2043): 	at com.android.internal.view.menu.ContextMenuBuilder.show(ContextMenuBuilder.java:81)
E/GeckoApp( 2043): 	at com.android.internal.policy.impl.PhoneWindow$DecorView.showContextMenuForChild(PhoneWindow.java:2144)
E/GeckoApp( 2043): 	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:564)
E/GeckoApp( 2043): 	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:564)
E/GeckoApp( 2043): 	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:564)
E/GeckoApp( 2043): 	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:564)
E/GeckoApp( 2043): 	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:564)
E/GeckoApp( 2043): 	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:564)
E/GeckoApp( 2043): 	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:564)
E/GeckoApp( 2043): 	at android.widget.AbsListView.performLongPress(AbsListView.java:2585)
E/GeckoApp( 2043): 	at android.widget.AbsListView$CheckForLongPress.run(AbsListView.java:2530)
E/GeckoApp( 2043): 	at android.os.Handler.handleCallback(Handler.java:605)
E/GeckoApp( 2043): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoApp( 2043): 	at android.os.Looper.loop(Looper.java:137)
E/GeckoApp( 2043): 	at org.mozilla.gecko.GeckoApp$33.run(GeckoApp.java:1512)
E/GeckoApp( 2043): 	at android.os.Handler.handleCallback(Handler.java:605)
E/GeckoApp( 2043): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoApp( 2043): 	at android.os.Looper.loop(Looper.java:137)
E/GeckoApp( 2043): 	at android.app.ActivityThread.main(ActivityThread.java:4424)
E/GeckoApp( 2043): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoApp( 2043): 	at java.lang.reflect.Method.invoke(Method.java:511)
E/GeckoApp( 2043): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
E/GeckoApp( 2043): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
E/GeckoApp( 2043): 	at dalvik.system.NativeStart.main(Native Method)
D/Zygote  (   81): Process 2043 exited cleanly (1)
I/ActivityManager(  155): Process org.mozilla.fennec (pid 2043) has died.
I/WindowManager(  155): WIN DEATH: Window{415f0020 SurfaceView paused=false}
I/WindowManager(  155): WIN DEATH: Window{415766b0 org.mozilla.fennec/org.mozilla.fennec.App paused=false}
W/ActivityManager(  155): Force removing ActivityRecord{415a8310 org.mozilla.fennec/org.mozilla.gecko.AwesomeBar}: app died, no saved state

Comment 2

[Cristian Nicolae (:xti)]

https://crash-stats.mozilla.com/report/index/bp-16e675fc-8fe5-4ce1-8e0f-84bac2111221

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

History list is apparently an ExpandedListView and doesn't have a cursor controlling it either. This adapts our code to handle both Cursors and Maps.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583652 [details] [diff] [review]
Patch

Looks like you covered all the listviews. Is this ready for review?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://crash-stats.mozilla.com/report/index/24e0dfd6-5ddf-4bd8-b570-ea27a2111226

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583652 [details] [diff] [review]
Patch

Tested the 3 different listviews - they all work without crashing.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e63189dcf24c

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

forgot to qref after removing a debugging Log
https://hg.mozilla.org/integration/mozilla-inbound/rev/02f09fcbf282

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/e63189dcf24c
https://hg.mozilla.org/mozilla-central/rev/02f09fcbf282

Is Aurora 11 affected?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583652 [details] [diff] [review]
Patch

Yes, this patch is needed on aurora

Comment 11

[LegNeato]

Comment on attachment 583652 [details] [diff] [review]
Patch

[triage comment]
Approved for aurora. Fixes a crash in native UI.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

combined patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/70ddf5c18897

Comment 13

[Aaron Train [:aaronmt]]

Samsung Galaxy SII (Android 2.3.4)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20111228 Firefox/12.0a1 Fennec/12.0a1
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20111228 Firefox/11.0a2 Fennec/11.0a1