712734 - [et] Search Engine modification for Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: et / Estonian, defect)

Description

[Sander Lepik]

"Mark Banner rejected sign-off by Sander Lepik on Dec. 20, 2011:
Whilst this looks technically fine, please submit a bug as previously announced for the search plugin changes: http://groups.google.com/group/mozilla.dev.l10n/browse_thread/thread/d38195b734f34987#"

I think the changes have been reviewd.

Comment 1

[Sander Lepik]

Ping.

I would like to sign off my work for beta so it would get some testing before release..

Comment 2

[Mark Banner (:standard8)]

Sorry for the delay.

For future reference: Same search engines as for Firefox.

In the wikipedia-et.xml file, please can you remove the following line for now:

<Param name="sourceid" value="Mozilla-search"/>

r=Standard8 with that fixed.

Please don't forget to do that on both aurora and beta branches, and update your sign-offs on both of those branches.

Thanks.

Comment 3

[Sander Lepik]

http://hg.mozilla.org/releases/l10n/mozilla-aurora/et/raw-rev/e32ae933bba0 patch for beta tree. I don't have that tree, i only keep aurora, so you can patch beta (sorry, i don't feel this to be my problem :/).

Comment 4

[Mark Banner (:standard8)]

Thanks. I've pushed the patch to beta here:

http://hg.mozilla.org/releases/l10n/mozilla-beta/et/rev/4a27bca9d204

I'll update your sign-off once the dashboard picks it up.

Comment 5

[Mark Banner (:standard8)]

I've signed off beta, and I've updated the sign off on aurora to include the additional fix so that I don't need to re-look up next time around. Obviously you still need to complete the work on aurora for TB 11.

Many thanks for your hard work.