712747 - Clang Static Analysis: Assigned value is garbage or undefined netwerk/socket/nsSOCKSIOLayer.cpp

Status: RESOLVED WONTFIX

(Core :: Networking: Proxy, defect, P3)

Description

[Christian Holler (:decoder)]

The following report (in the URL field) has been generated by static analysis using Clang.

In this particular report, the problem is that the function | nsSOCKSSocketInfo::ReadNetAddr | does not handle the case where the | fam | parameter is not either | PR_AF_INET | or | PR_AF_INET6 |. I checked the code and this function only seems to be used twice and there INET/INET6 is used. Nevertheless, would it make sense to add an else branch covering the wrong usage? (Probably just setting addr to NULL and returning). If that doesn't make sense at all, just close this bug :)

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Unassigning bugs owned by Patrick.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

This can only be used with AF_INET and AF_INET6; if we don't understand the protocol we can't pull data from the reader for it, so simply not pulling anything is reasonable. We shouldn't clear addr