712760 - Add smaller font size options

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[matthias koplenig [:metasieben]]

compared to android-browser all text is rendered to big (which makes some websites look broken). afaics google has added a min-font size slider, and set it to 1, while the min-font-size in nightly seems to be much bigger.

maybe adding the option to set the font-size to >tiny< (eg. min-font-size: 1pt) would suffice.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Matthias, can you let me know which version of nightly you're using and include some screenshots of the problem websites?

Comment 2

[matthias koplenig [:metasieben]]

sorry for the delay.
did some more checks and added some screens to this bug. hope those helps.

Comment 3

[matthias koplenig [:metasieben]]

Attachment: font options in gmail-app

Comment 4

[matthias koplenig [:metasieben]]

Attachment: font(accessibility)-options in android-browser

Comment 5

[matthias koplenig [:metasieben]]

Attachment: m.derstandard.at …with min-font size set to 1pt

Comment 6

[matthias koplenig [:metasieben]]

Attachment: m.derstandard.at …as rendered with firefox-stable/XUL

Comment 7

[matthias koplenig [:metasieben]]

Attachment: m.derstandard.at …as rendered with nightly (font-size: small)

Comment 8

[Aaron Train [:aaronmt]]

Not sure if this is related; but I have a simple enough patch I used for personal testing that added extra small. 

http://people.mozilla.com/~atrain/mobile/xsmall.patch

Comment 9

[Matt Brubeck (:mbrubeck)]

Attachment: patch

After consultation with Madhava and Patryk, we decided to add two smaller options: "Tiny" which sets the minimum size to 0 (disabling font inflation) and "Small" (4pt).

The default size remains the same (6pt) but is now called "Medium", and the "Large" and "Extra-Large" sizes are reduced slightly.

This also changes the name of the preference from "Font size" to "Text size" to reduce jargon and improve consistency with Android.

Note that the list of font sizes with names will be replaced soon by a preview with zoom buttons (bug 715179).  At that point we can provide a wider range of sizes without having to designate names for each one.

Comment 10

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8ede0b17a1c

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 588519 [details] [diff] [review]
patch

[Approval Request Comment]
Resource-only, Android-only patch to tweak some preference values.  This makes our text-inflation feature usable for a wider range of display sizes and users.  It also includes a minor string change requested by UX.

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/b8ede0b17a1c

Comment 13

[Alex Keybl [:akeybl]]

Leaving in the aurora approval queue until this has been pushed to the nightly audience.

Comment 14

[Alex Keybl [:akeybl]]

Comment on attachment 588519 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 15

[Aaron Train [:aaronmt]]

Verified on M-C

Samsung Galaxy SII (Android 2.3.4) & Nexus S (Android 4.0.3)
20120119042014
http://hg.mozilla.org/mozilla-central/rev/78f821cb8974

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5222a2f174c4

Comment 17

[Aaron Train [:aaronmt]]

Verified on M-A
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a