compile warnings in nsExternalHelperAppService.cpp

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
19 years ago
16 years ago

People

(Reporter: colin, Assigned: mscott)

Tracking

(Blocks 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Couple of compile warnings in uriloader/exthandler/nsExternalHelperAppService.cpp

Looks like we're passing -1 where an unsigned is required.

http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/nsExternalHelperAppService.cpp#628

     dispositionValue.Mid(dispFileName, pos + nsCRT::strlen("filename="), -1);
..........................................................................^

%CXX-W-INTSIGNCHANGE, integer conversion resulted in a change of sign


http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/nsExternalHelperAppService.cpp#771

  rv = fileTransport->OpenOutputStream(0, -1, 0, getter_AddRefs(mOutStream));
..........................................^
%CXX-W-INTSIGNCHANGE, integer conversion resulted in a change of sign
-->mscott, cc'ing dougt
Assignee: neeti → mscott
I take responsiblity only for the second warning listed here.  It is a known
"problem" and we are going to add a #define which can be used instead of (-1)
which will properly cast to avoid this warning.
mass move, v2.
qa to me.
QA Contact: tever → benc
The first of those two lines is no more, the second has become 

1081   rv = fileTransport->OpenOutputStream(0, PRUint32(-1), 0,
getter_AddRefs(mOutStream));  

So the warnings are gone.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Not sure whether they deserve a new bug or not, but there is a bunch of new
warnings:

/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:100:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:100:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:101:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:101:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:102:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:102:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:103:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:103:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:104:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:104:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:105:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:105:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:109:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:109:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:110:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:110:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:111:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:111:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:120:
warning: multi-character character constant
/mnt/3/tinderbox/brad/Linux_2.4.18-pre3_Clobber/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp:120:
warning: multi-character character constant
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: buildwarning
Whiteboard: DUPEME(FIXED)
those got fixed in bug 120045. not marking duplicate because this also covered
other warnings it seems.
Status: REOPENED → RESOLVED
Closed: 17 years ago16 years ago
Resolution: --- → FIXED
Whiteboard: DUPEME(FIXED)
You need to log in before you can comment on or make changes to this bug.