The default bug view has changed. See this FAQ.

IonMonkey: implement OSI thunk on ARM

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cdleary, Assigned: mjrosenb)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Similar to other architectures, we just wanted to get x86/x64 in early for testing over winter break.
(Assignee)

Comment 1

5 years ago
Created attachment 585625 [details] [diff] [review]
Implement OSI on ARM.

David said this was higher priority than ICs, and you weren't around, so I went ahead and implemented this.
Assignee: christopher.leary → mrosenberg
Attachment #585625 - Flags: review?(christopher.leary)
Comment on attachment 585625 [details] [diff] [review]
Implement OSI on ARM.

Review of attachment 585625 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing that.

::: js/src/ion/arm/Trampoline-arm.cpp
@@ +317,5 @@
> +    // - Push the machine state onto the stack.
> +    // - Call the InvalidationBailout routine with the stack pointer.
> +    // - Now that the frame has been bailed out, convert the invalidated
> +    //   frame into an exit frame.
> +    // - Do the normal check-return-code-and-thunk-to-the-interpreter dance.

On x64 I told people to look at the comment in the x86 generateInvalidator implementation -- unless there's differences here (in which case we should probably just put the differences) we should do the same citation here to avoid staleness of big comments.
Attachment #585625 - Flags: review?(christopher.leary) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.