Last Comment Bug 712846 - IonMonkey: implement OSI thunk on ARM
: IonMonkey: implement OSI thunk on ARM
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: ARM All
: -- normal (vote)
: ---
Assigned To: Marty Rosenberg [:mjrosenb]
:
Mentors:
Depends on: IonOSI
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-21 18:17 PST by Chris Leary [:cdleary] (not checking bugmail)
Modified: 2012-01-30 15:48 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Implement OSI on ARM. (8.61 KB, patch)
2012-01-03 18:39 PST, Marty Rosenberg [:mjrosenb]
cdleary: review+
Details | Diff | Review

Description Chris Leary [:cdleary] (not checking bugmail) 2011-12-21 18:17:11 PST
Similar to other architectures, we just wanted to get x86/x64 in early for testing over winter break.
Comment 1 Marty Rosenberg [:mjrosenb] 2012-01-03 18:39:55 PST
Created attachment 585625 [details] [diff] [review]
Implement OSI on ARM.

David said this was higher priority than ICs, and you weren't around, so I went ahead and implemented this.
Comment 2 Chris Leary [:cdleary] (not checking bugmail) 2012-01-04 13:59:32 PST
Comment on attachment 585625 [details] [diff] [review]
Implement OSI on ARM.

Review of attachment 585625 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing that.

::: js/src/ion/arm/Trampoline-arm.cpp
@@ +317,5 @@
> +    // - Push the machine state onto the stack.
> +    // - Call the InvalidationBailout routine with the stack pointer.
> +    // - Now that the frame has been bailed out, convert the invalidated
> +    //   frame into an exit frame.
> +    // - Do the normal check-return-code-and-thunk-to-the-interpreter dance.

On x64 I told people to look at the comment in the x86 generateInvalidator implementation -- unless there's differences here (in which case we should probably just put the differences) we should do the same citation here to avoid staleness of big comments.

Note You need to log in before you can comment on or make changes to this bug.