Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Style Editor should always show the Save button on the currently edited style sheet

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Developer Tools: Style Editor
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cedricv, Unassigned)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(firefox11 verified)

Details

(Whiteboard: [qa+][qa!:11])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Imho an unseen regression brought with the new skin.

The selected style sheet should have the Save action visible at all times for discoverability's sake - currently you have no visible way to know how to save (only Ctrl-S)
(Reporter)

Comment 1

6 years ago
Created attachment 583740 [details] [diff] [review]
patch
Attachment #583740 - Flags: review?(paul)

Updated

6 years ago
Attachment #583740 - Flags: review?(paul) → review+

Updated

6 years ago
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/5bbf02ceb383
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: NEW → ASSIGNED
(Reporter)

Comment 3

6 years ago
Comment on attachment 583740 [details] [diff] [review]
patch

I believe this might be a good candidate for Aurora.
This is a minimal change that fixes an UI regression introduced with the new skin in bug 687702 (which landed shortly before branching)
Attachment #583740 - Flags: approval-mozilla-aurora?

Comment 4

6 years ago
Comment on attachment 583740 [details] [diff] [review]
patch

[Triage Comment]
Please re-nominate once this has landed on m-c and had at least a couple of days to bake.
Attachment #583740 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
https://hg.mozilla.org/mozilla-central/rev/5bbf02ceb383
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12

Comment 6

6 years ago
Comment on attachment 583740 [details] [diff] [review]
patch

Re-noming as requested, this landed the 29th.
Attachment #583740 - Flags: approval-mozilla-aurora- → approval-mozilla-aurora?

Comment 7

6 years ago
Comment on attachment 583740 [details] [diff] [review]
patch

[Triage Comment]
Thanks! Approved for Aurora.
Attachment #583740 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/99737dbc0bda
Assignee: cedricv → nobody
status-firefox11: --- → fixed
Verified on Build identifier: Mozilla/5.0 (X11; Linux i686; rv:12.0a1) Gecko/20120125 Firefox/12.0a1
Whiteboard: [qa+]
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0

Verified that "Save" button is always shown on the currently edited style sheet using Firefox 11 beta 1 on Win 7, Ubuntu 11.10 and Mac OS X 10.6.
status-firefox11: fixed → verified
Whiteboard: [qa+] → [qa+][qa!:11]
You need to log in before you can comment on or make changes to this bug.