712959 - Image decoding prefs aren't reloaded when they change

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Justin Lebar (not reading bugmail)]

There's no good reason for this; just an omission in the pref tracking code.

I'll rewrite the code to use the new pref caches.  It's much cleaner.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Review: joedrew!

Comment 2

[Justin Lebar (not reading bugmail)]

> Review: joedrew!

Hm, that didn't work quite as I'd intended.  :)

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 583825 [details] [diff] [review]
Patch v1

Review of attachment 583825 [details] [diff] [review]:
-----------------------------------------------------------------

DiscardTracker.cpp |   14 ++++++-
 RasterImage.cpp    |   39 ++++++++++++---------
 RasterImage.h      |    5 --
 imgRequest.cpp     |   94 ++++++-----------------------------------------------
 4 files changed, 45 insertions(+), 107 deletions(-)

Yes, this'll do.

::: image/src/RasterImage.cpp
@@ +86,5 @@
>  #endif
>  
> +// Tweakable progressive decoding parameters.  These are initialized to 0 here
> +// because otherwise, we have to initialize them in a static initializer, which
> +// makes us slower to start up.

All globals are initialized to zero as they're in the .bss section, right?

Comment 4

[Justin Lebar (not reading bugmail)]

> All globals are initialized to zero as they're in the .bss section, right?

Yes.  And because the whole page comes in as zeroed, this is faster than initializing to something else.

Comment 5

[Justin Lebar (not reading bugmail)]

Thanks, Joe.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e251ac6325b4

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/e251ac6325b4

Comment 7

[u279076]

Is there something QA can do to test this?