712980 - java.lang.NullPointerException @ org.mozilla.gecko.GeckoPreferences.onPreferenceChange(GeckoPreferences.java:145)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

E/GeckoApp(  989): top level exception
E/GeckoApp(  989): java.lang.NullPointerException
E/GeckoApp(  989): 	at org.mozilla.gecko.GeckoPreferences.onPreferenceChange(GeckoPreferences.java:145)
E/GeckoApp(  989): 	at android.preference.Preference.callChangeListener(Preference.java:756)
E/GeckoApp(  989): 	at org.mozilla.gecko.LinkPreference.onClick(LinkPreference.java:59)
E/GeckoApp(  989): 	at android.preference.Preference.performClick(Preference.java:810)
E/GeckoApp(  989): 	at android.preference.PreferenceScreen.onItemClick(PreferenceScreen.java:190)
E/GeckoApp(  989): 	at android.widget.AdapterView.performItemClick(AdapterView.java:284)
E/GeckoApp(  989): 	at android.widget.ListView.performItemClick(ListView.java:3513)
E/GeckoApp(  989): 	at android.widget.AbsListView$PerformClick.run(AbsListView.java:1812)
E/GeckoApp(  989): 	at android.os.Handler.handleCallback(Handler.java:587)
E/GeckoApp(  989): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoApp(  989): 	at android.os.Looper.loop(Looper.java:130)
E/GeckoApp(  989): 	at org.mozilla.gecko.GeckoApp$33.run(GeckoApp.java:1517)
E/GeckoApp(  989): 	at android.os.Handler.handleCallback(Handler.java:587)
E/GeckoApp(  989): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoApp(  989): 	at android.os.Looper.loop(Looper.java:130)
E/GeckoApp(  989): 	at android.app.ActivityThread.main(ActivityThread.java:3683)
E/GeckoApp(  989): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoApp(  989): 	at java.lang.reflect.Method.invoke(Method.java:507)
E/GeckoApp(  989): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
E/GeckoApp(  989): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
E/GeckoApp(  989): 	at dalvik.system.NativeStart.main(Native Method)

STR:
1. Settings -> About Nightly

--
Samsung Galaxy SII (Android 2.3.4)
20111222081210
http://hg.mozilla.org/integration/mozilla-inbound/rev/6707b2415598

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 584302 [details] [diff] [review]
patch


>diff --git a/mobile/android/base/GeckoPreferences.java b/mobile/android/base/GeckoPreferences.java

Some of our preferences do not have a prefName (key) so this would short-circuit some logic.

>     public boolean onPreferenceChange(Preference preference, Object newValue) {
>+        if (preference == null)
>+            return false;

This should never happen, but we can keep it

>+        if (prefName == null)
>+            return false;

This isn't quite right. Let's not do it. Maybe we could add a comment that prefName can be NULL ?

>         if (prefName.equals("privacy.masterpassword.enabled")) {

          if (prefName != null && prefName.equals("privacy.masterpassword.enabled")) {

This should be enough to fix the problem, right?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://crash-stats.mozilla.com/report/index/e6d82c3d-057e-4099-9245-afe3d2111226

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/284800b71c20

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 584326 [details] [diff] [review]
patch

crash fix

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/284800b71c20

Comment 9

[LegNeato]

Comment on attachment 584326 [details] [diff] [review]
patch

[triage comment]
Approved for aurora. Mobile only, fixes a crash with easy STR.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a57df475441d

Comment 11

[Aaron Train [:aaronmt]]

Samsung Galaxy SII (Android 2.3.4)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20111228 Firefox/12.0a1 Fennec/12.0a1
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20111228 Firefox/11.0a2 Fennec/11.0a1