Endian issue with YarrJIT

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: spectre, Assigned: spectre)

Tracking

12 Branch
mozilla12
Other
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 583827 [details] [diff] [review]
Big endian fix for YarrJIT ignoreCase

http://code.google.com/p/tenfourfox/issues/detail?id=120

Although PowerPC JM+TI is currently stillborne -_-, we are making use of our macroassembler for YARR and Ben Stuhl, one of our TenFourFox contributors, discovered an endianness issue with YARR JIT. It's a small patch and I figured we should push it upstream for SPARC and (future) MIPS consumers. Ben's notes:

I built js/ from 10.4Fx 9 and ran 'make check jstests'. It revealed a few failures, including several; in ecma_3/RegExp/perlstress-001.js, which can be reduced to

'A]'.match(/a]/i) == null /* should be 'A]' */

. I get the same result running the test by hand in the Web Console in 10.4Fx 9.

It turns out to be a minor endian bug in YARR; here's a patch.
(Assignee)

Updated

6 years ago
Attachment #583827 - Flags: review?(dmandelin)
Attachment #583827 - Attachment is patch: true
Attachment #583827 - Flags: review?(dmandelin) → review+
Did you file a bug with WebKit too?
(Assignee)

Comment 2

6 years ago
Not yet, I'll do that too. Thanks for the review!
Assignee: general → spectre
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/334f198c10b5
Keywords: checkin-needed
Target Milestone: --- → mozilla12

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/334f198c10b5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.