713119 - Make AddonRepository.getAddonsByIDs() not send performance data

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 1]

+++ This bug was initially created as a clone of Bug #682356 +++

Currently, the AddonRepository APIs for searching (specifically getAddonsByIDs()) automatically send performance metrics to the server.

Per discussion in bug 534956 (implementing add-on sync), having Sync query these APIs will have the undesired effect of skewing the metrics data.

AddonRepository.getAddonsByIDs() should be modified so that it optionally doesn't send performance data as part of the request and Sync can call it without skewing metrics data.

Original changeset: http://hg.mozilla.org/mozilla-central/rev/259bae11858b

From the Error Console of a build without this patch:

Timestamp: 22.12.2011 23:29:58
Error: formatURL: Couldn't find value for key: TIME_MAIN
Source File: file:///e:/mozilla-src/seamonkey-central/mozilla/dist/bin/components/nsURLFormatter.js
Line: 131

Timestamp: 22.12.2011 23:29:58
Error: formatURL: Couldn't find value for key: TIME_FIRST_PAINT
Source File: file:///e:/mozilla-src/seamonkey-central/mozilla/dist/bin/components/nsURLFormatter.js
Line: 131

Timestamp: 22.12.2011 23:29:58
Error: formatURL: Couldn't find value for key: TIME_SESSION_RESTORED
Source File: file:///e:/mozilla-src/seamonkey-central/mozilla/dist/bin/components/nsURLFormatter.js
Line: 131

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 583945 [details] [diff] [review]
patch [Checkin: comment 1]

http://hg.mozilla.org/comm-central/rev/65b901f262c0
http://hg.mozilla.org/releases/comm-aurora/rev/90b62372bc88