Closed Bug 713149 Opened 10 years ago Closed 10 years ago

hal_impl has no method GetCurrentBatteryInformation

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file, 1 obsolete file)

Tiny error that keeps the patch landed in bug 696042 from compiling.
Attached patch fix (obsolete) — Splinter Review
Attachment #583963 - Flags: review?(mwu)
Comment on attachment 583963 [details] [diff] [review]
fix

Hm, I remember putting this here because it made the function call unambiguous. Well, whatever works.
Attachment #583963 - Flags: review?(mwu) → review+
Since this code was written, the semi-private methods were split out of Hal.h into HalImpl.h.

Instead of this patch, please add an #include "HalImpl.h" after "Hal.h".
Attached patch better fixSplinter Review
Makes sense, Chris. Here's an updated patch that I'll push in a bit.
Attachment #583963 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f50fd00d1c0b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.