Last Comment Bug 713149 - hal_impl has no method GetCurrentBatteryInformation
: hal_impl has no method GetCurrentBatteryInformation
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla12
Assigned To: Philipp von Weitershausen [:philikon]
:
Mentors:
Depends on:
Blocks: 696042
  Show dependency treegraph
 
Reported: 2011-12-22 16:20 PST by Philipp von Weitershausen [:philikon]
Modified: 2011-12-24 22:11 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (384 bytes, patch)
2011-12-22 16:22 PST, Philipp von Weitershausen [:philikon]
mwu.code: review+
Details | Diff | Splinter Review
better fix (340 bytes, patch)
2011-12-23 20:58 PST, Philipp von Weitershausen [:philikon]
no flags Details | Diff | Splinter Review

Description Philipp von Weitershausen [:philikon] 2011-12-22 16:20:31 PST
Tiny error that keeps the patch landed in bug 696042 from compiling.
Comment 1 Philipp von Weitershausen [:philikon] 2011-12-22 16:22:03 PST
Created attachment 583963 [details] [diff] [review]
fix
Comment 2 Michael Wu [:mwu] 2011-12-22 16:56:27 PST
Comment on attachment 583963 [details] [diff] [review]
fix

Hm, I remember putting this here because it made the function call unambiguous. Well, whatever works.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-22 19:17:47 PST
Since this code was written, the semi-private methods were split out of Hal.h into HalImpl.h.

Instead of this patch, please add an #include "HalImpl.h" after "Hal.h".
Comment 4 Philipp von Weitershausen [:philikon] 2011-12-23 20:58:38 PST
Created attachment 584158 [details] [diff] [review]
better fix

Makes sense, Chris. Here's an updated patch that I'll push in a bit.
Comment 5 Philipp von Weitershausen [:philikon] 2011-12-23 21:07:13 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/f50fd00d1c0b
Comment 6 Phil Ringnalda (:philor, back in August) 2011-12-24 22:11:43 PST
https://hg.mozilla.org/mozilla-central/rev/f50fd00d1c0b

Note You need to log in before you can comment on or make changes to this bug.