Last Comment Bug 713168 - Hack in support for maguro touch screen
: Hack in support for maguro touch screen
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla12
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
Depends on:
Blocks: 712973
  Show dependency treegraph
 
Reported: 2011-12-22 18:42 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2011-12-30 04:57 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add support for different screen/input-device resolutions and virtual buttons. Temporary. (21.83 KB, patch)
2011-12-22 19:42 PST, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
mwu.code: review+
Details | Diff | Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-22 18:42:35 PST
The maguro's screen uses a different coordinate space than the sgs2's, and it also has virtual buttons.  The forthcoming patch hacks in support for those, but it's as far as I want to take this hackery in nsAppShell.  All new work goes towards bug 712973, including orientation support.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-22 19:42:00 PST
Created attachment 583996 [details] [diff] [review]
Add support for different screen/input-device resolutions and virtual buttons. Temporary.
Comment 2 Michael Wu [:mwu] 2011-12-29 09:48:09 PST
Comment on attachment 583996 [details] [diff] [review]
Add support for different screen/input-device resolutions and virtual buttons. Temporary.

Rubberstamp review. We're just gonna throw all this code out anyway.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-29 14:49:00 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/87d4fca7a8e2
Comment 4 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2011-12-30 04:57:20 PST
https://hg.mozilla.org/mozilla-central/rev/87d4fca7a8e2

Note You need to log in before you can comment on or make changes to this bug.