Last Comment Bug 713169 - gfx/skia/src/core/SkAdvancedTypefaceMetrics.cpp:163: error: explicit instantiation of non-template 'SkAdvancedTypefaceMetrics::AdvanceMetric<short int>* skia_advanced_typeface_metrics_utils::getAdvanceData'
: gfx/skia/src/core/SkAdvancedTypefaceMetrics.cpp:163: error: explicit instanti...
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla12
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
:
Mentors:
Depends on:
Blocks: 709193
  Show dependency treegraph
 
Reported: 2011-12-22 19:23 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-05-01 04:26 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Build skia for MOZ_WIDGET_TOOLKIT=android (869 bytes, patch)
2011-12-22 19:38 PST, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
khuey: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-22 19:23:45 PST
When building for gonk.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-22 19:38:57 PST
Created attachment 583995 [details] [diff] [review]
Build skia for MOZ_WIDGET_TOOLKIT=android

OS_TARGET=Android for both gonk and android.
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-25 09:18:21 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2a74fb2086a
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-25 09:49:31 PST
I came across 

https://github.com/cgjones/mozilla-central/commit/2466377

in our b2g downstream fork, which doesn't seem to be tracked by a bugzilla bug.  That patch enables building skia for gonk, AFAICT.  I don't think we want to do that; skia is one of the libraries that oems/chipset folks customize, so I think we'll want to use the skia from alternate repos.

That patch conflicts with this one here, which simply disables skia for gonk.  When this bug gets ready to merge into b2g downstream, I'm going to revert the previous commit, and we can carry on the "whither skia?" in another forum.
Comment 4 Justin Lebar (not reading bugmail) 2011-12-25 10:49:42 PST
> I'm going to revert the previous commit, and we can carry on the "whither skia?" in 
> another forum.

sgtm.  I think mwu and I didn't really know what was going on here; we just wanted to make it compile.  :)
Comment 5 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-25 10:53:43 PST
No worries!  Thanks for fixing the build :).
Comment 6 Phil Ringnalda (:philor) 2011-12-25 20:54:27 PST
https://hg.mozilla.org/mozilla-central/rev/f2a74fb2086a

Note You need to log in before you can comment on or make changes to this bug.