713169 - gfx/skia/src/core/SkAdvancedTypefaceMetrics.cpp:163: error: explicit instantiation of non-template 'SkAdvancedTypefaceMetrics::AdvanceMetric<short int>* skia_advanced_typeface_metrics_utils::getAdvanceData'

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

When building for gonk.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Build skia for MOZ_WIDGET_TOOLKIT=android

OS_TARGET=Android for both gonk and android.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2a74fb2086a

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I came across 

https://github.com/cgjones/mozilla-central/commit/2466377

in our b2g downstream fork, which doesn't seem to be tracked by a bugzilla bug.  That patch enables building skia for gonk, AFAICT.  I don't think we want to do that; skia is one of the libraries that oems/chipset folks customize, so I think we'll want to use the skia from alternate repos.

That patch conflicts with this one here, which simply disables skia for gonk.  When this bug gets ready to merge into b2g downstream, I'm going to revert the previous commit, and we can carry on the "whither skia?" in another forum.

Comment 4

[Justin Lebar (not reading bugmail)]

> I'm going to revert the previous commit, and we can carry on the "whither skia?" in 
> another forum.

sgtm.  I think mwu and I didn't really know what was going on here; we just wanted to make it compile.  :)

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

No worries!  Thanks for fixing the build :).

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f2a74fb2086a