Closed Bug 713169 Opened 13 years ago Closed 13 years ago

gfx/skia/src/core/SkAdvancedTypefaceMetrics.cpp:163: error: explicit instantiation of non-template 'SkAdvancedTypefaceMetrics::AdvanceMetric<short int>* skia_advanced_typeface_metrics_utils::getAdvanceData'

Categories

(Core :: Graphics, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: cjones, Assigned: cjones)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

When building for gonk.
OS_TARGET=Android for both gonk and android.
Assignee: nobody → jones.chris.g
Attachment #583995 - Flags: review?(khuey)
I came across 

https://github.com/cgjones/mozilla-central/commit/2466377

in our b2g downstream fork, which doesn't seem to be tracked by a bugzilla bug.  That patch enables building skia for gonk, AFAICT.  I don't think we want to do that; skia is one of the libraries that oems/chipset folks customize, so I think we'll want to use the skia from alternate repos.

That patch conflicts with this one here, which simply disables skia for gonk.  When this bug gets ready to merge into b2g downstream, I'm going to revert the previous commit, and we can carry on the "whither skia?" in another forum.
> I'm going to revert the previous commit, and we can carry on the "whither skia?" in 
> another forum.

sgtm.  I think mwu and I didn't really know what was going on here; we just wanted to make it compile.  :)
No worries!  Thanks for fixing the build :).
https://hg.mozilla.org/mozilla-central/rev/f2a74fb2086a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Blocks: 750661
No longer blocks: 750661
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: