Closed
Bug 71317
Opened 24 years ago
Closed 24 years ago
leak increase on tinderbox
Categories
(Core :: Networking, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: dbaron, Assigned: darin.moz)
References
Details
(Keywords: memory-leak, Whiteboard: [tind-mlk])
Attachments
(1 file)
|
1.82 KB,
patch
|
Details | Diff | Splinter Review |
DESCRIPTION: Sometime between 2001-03-07 23:38 and 2001-03-08 00:16 the leaks
on tinderbox increased from about 2K to 14K.
Checkins during that time period:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2001-03-07+23%3A38&maxdate=2001-03-08+00%3A16&cvsroot=%2Fcvsroot
Leak stats showing changes:
--ALL-LEAKS-----------------------------------leaks------leaks%-----------------------
TOTAL 14156 523.06%
nsHeaderEntry 1200 -
nsHashtable 1188 2600.00%
nsStr 1100 450.00%
nsSupportsArray 1080 -
nsSocketTransport 780 200.00%
nsStringKey 480 -
ImageNetContextImpl 480 15.38%
nsHashKey 392 -
nsPresState 384 -
nsHTTPChannel 344 -
AtomImpl 336 -
nsDocShell 292 -
nsFtpControlConnection 292 0.00%
nsRDFResource 260 -
nsImageGTK 252 0.00%
GlobalWindowImpl 244 -
ImgDCallbk 240 15.38%
nsSupportsPRInt32Impl 224 -
nsProxyEventObject 224 -
nsHTTPPipelinedRequest 224 -
nsSocketRequest 216 285.71%
nsHTTPResponse 200 -
nsHTTPRequest 200 -
nsProxyObject 196 -
nsVoidArray 192 84.62%
xptiInterfaceInfo 180 -
nsEventListenerManager 168 -
nsSupportsStringImpl 160 -
nsProxyEventClass 144 -
nsDeviceContextGTK 140 -
nsDocLoaderImpl 136 -
nsGlobalHistory 124 -
nsLocalFile 116 -
nsXPCComponents 104 -
nsStreamProxyBase 100 150.00%
nsPipe 96 0.00%
nsXPCWrappedNative 96 -
nsSHEntry 76 -
nsSocketIS 72 200.00%
nsSocketOS 72 200.00%
nsMemoryImpl 68 0.00%
nsSocketTransportService 64 0.00%
nsXULPDGlobalObject 64 -
BasicStringImpl 64 -
nsXPCWrappedNativeScope 64 -
nsEventQueueServiceImpl 60 -
RDFServiceImpl 60 -
nsLayoutHistoryState 56 -
nsSystemPrincipal 52 -
GIFDecoder 48 0.00%
nsPref 48 -
nsTimerGtk 48 -
nsXPCWrappedNativeClass 48 -
nsSimpleStreamProvider 40 -
nsFocusController 36 -
nsXBLWindowKeyHandler 36 -
nsEventQueueImpl 36 0.00%
nsWindowRoot 32 -
nsStringBundle 32 -
nsFileSpecImpl 32 -
nsScreenGtk 32 -
nsSingleSignOnPrompt 28 -
ImageRequestImpl 28 -
nsFileLogEventSink 28 0.00%
ImageRendererImpl 24 100.00%
nsPersistentProperties 24 -
nsDOMWindowPrompter 20 -
nsScreenManagerGtk 20 -
nsGenericFactory 20 -
nsDocumentCharsetInfo 20 -
nsStdURL 20 -
nsDefaultURIFixup 16 -
nsFtpStreamProvider 16 -
nsStdURLParser 12 -
nsCommonDialogs 12 -
nsFontCache 12 -
nsAuthURLParser 12 -
nsNoAuthURLParser 12 -
nsSimpleURI 4 -
nsLoadGroup 4 -
--CLASSES-NOT-REPORTED-LAST-TIME--------------leaks------bloat------------------------
nsUnknownDecoder 0 52
DataRequestForwarder 0 28
nsStreamConverterService 0 16
TOTAL 0 96
--CLASSES-THAT-WENT-AWAY----------------------leaks------bloat------------------------
nsOnDataWritableEvent 0 960
nsStreamListenerEvent 0 52
nsAsyncStreamListener 0 24
nsAsyncStreamObserver 0 20
TOTAL 0 1056
|
Assignee | |
Updated•24 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•24 years ago
|
||
|
||
Comment 2•24 years ago
|
||
darin your fix looks correct to me. The only concern I have is are we exposing
ourselves to a potential crash by nulling out mObserver after the OnStop call.
I'm pretty sure we won't 'cause the observer won't be expecting any other calls
after OnStop nor would the socket really be making any. sr=mscott
|
||
Comment 3•24 years ago
|
||
sr=alecf
|
||
Comment 4•24 years ago
|
||
r=bryner
|
|
Assignee | |
Comment 5•24 years ago
|
||
mscott: all calls to mObserver are prefixed by "if (mObserver)"
|
|
Assignee | |
Comment 6•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
||
Comment 9•24 years ago
|
||
verified with embed memory tests on linux gtkEmbed from this morning
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•