713300 - Crash [@ _objc_error] in -[BookmarkButton mouseDown:] and -[BookmarkButton showFolderPopup:]

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This bug was filed from the Socorro interface and is 
report bp-3e34bed9-c3f6-4e48-90c2-f15552111219 .
============================================================= 

The most common[1] 2.1 [@ _objc_error] crash is actually one in BookmarkButton:

0 	libobjc.A.dylib 	_objc_error 	
1 	libobjc.A.dylib 	__objc_error 	
2 	libobjc.A.dylib 	_freedHandler 	
3 	Camino 	-[BookmarkButton mouseDown:] 	src/bookmarks/BookmarkButton.mm:293
4 	AppKit 	-[NSWindow sendEvent:] 	
5 	AppKit 	-[NSApplication sendEvent:] 	
6 	AppKit 	-[NSApplication run] 	
7 	AppKit 	NSApplicationMain 	
8 	Camino 	main 	src/application/main.m:64

http://hg.mozilla.org/camino/annotate/a9b120648e7a/src/bookmarks/BookmarkButton.mm#l293

The only comment we have is "Moving tab groups from bookmark bar to folder"

There's a similar, but not quite as common, crash when showing the BookmarkButton folder menu:

0 	libobjc.A.dylib 	_objc_error 	
1 	libobjc.A.dylib 	__objc_error 	
2 	libobjc.A.dylib 	_freedHandler 	
3 	AppKit 	-[NSMenuItemCell setHighlighted:] 	
4 	AppKit 	-[NSPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:] 	
5 	Camino 	-[BookmarkButton showFolderPopup:] 	src/bookmarks/BookmarkButton.mm:282
6 	Camino 	-[BookmarkButton mouseDown:] 	src/bookmarks/BookmarkButton.mm:294
7 	AppKit 	-[NSWindow sendEvent:] 	
8 	AppKit 	-[NSApplication sendEvent:] 	
9 	AppKit 	-[NSApplication run] 	
10 	AppKit 	NSApplicationMain 	
11 	Camino 	main 	src/application/main.m:64

http://hg.mozilla.org/camino/annotate/a9b120648e7a/src/bookmarks/BookmarkButton.mm#l282

Stuart, can you check and see whether we're doing anything obviously wrong in either of those two places?

[1] There are also some less common crashes during drag operations, e.g. bp-f2dcbc9a-8c8f-4800-be2e-6a26d2111218.

Comment 1

[Stuart Morgan]

Nothing is jumping out at me. We should try playing with seeing if we can repro it (ideally with zombies enabled) by playing with dropping tab groups into folders with different timings.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Flagging this for 2.1.1 just so it stays on the radar, and hopefully I'll have a chance at some point to try to repro.

(These were mostly on 10.6.8, but that may just be because it's where the most users are.)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Still need to try and repro this; it's currently our (distant) #2 crash, well behind the CFRunLoopAddSource (QuickTimeIIDCDigitizer / QuickTimeUSBVDCDigitizer) crash triggered by Flash.