713416 - Remove unnecessary class nsUniCharEntry

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/src/mozPersonalDictionary.h#58 is just a duplicate of http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsHashKeys.h#374.

Comment 1

[Santiago Gimeno]

Attachment: Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

Review of attachment 584325 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Ehsan is the owner of this code, so lets get him to approve this change too.

Thanks for the patch!

Comment 3

[(no longer active)]

Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

This looks great, thanks a lot Santiago!  :-)

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cfe9f42a32

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d1cfe9f42a32