The default bug view has changed. See this FAQ.

Remove unnecessary class nsUniCharEntry

RESOLVED FIXED in mozilla12

Status

()

Core
Spelling checker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: Santiago Gimeno)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=khuey][lang=c++])

Attachments

(1 attachment)

http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/src/mozPersonalDictionary.h#58 is just a duplicate of http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsHashKeys.h#374.
(Assignee)

Comment 1

5 years ago
Created attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey
(Assignee)

Updated

5 years ago
Attachment #584325 - Flags: review?(khuey)
Assignee: nobody → santiago.gimeno
Status: NEW → ASSIGNED
Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

Review of attachment 584325 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Ehsan is the owner of this code, so lets get him to approve this change too.

Thanks for the patch!
Attachment #584325 - Flags: review?(khuey)
Attachment #584325 - Flags: review?(ehsan)
Attachment #584325 - Flags: review+
Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

This looks great, thanks a lot Santiago!  :-)
Attachment #584325 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cfe9f42a32
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/d1cfe9f42a32
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.