Last Comment Bug 713416 - Remove unnecessary class nsUniCharEntry
: Remove unnecessary class nsUniCharEntry
Status: RESOLVED FIXED
[mentor=khuey][lang=c++]
:
Product: Core
Classification: Components
Component: Spelling checker (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Santiago Gimeno
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-24 18:32 PST by Kyle Huey [:khuey] (khuey@mozilla.com)
Modified: 2011-12-29 03:34 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey (3.29 KB, patch)
2011-12-26 06:57 PST, Santiago Gimeno
khuey: review+
ehsan: review+
Details | Diff | Review

Comment 1 Santiago Gimeno 2011-12-26 06:57:38 PST
Created attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-12-26 07:04:52 PST
Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

Review of attachment 584325 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Ehsan is the owner of this code, so lets get him to approve this change too.

Thanks for the patch!
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2011-12-28 13:14:19 PST
Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

This looks great, thanks a lot Santiago!  :-)
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2011-12-28 13:26:34 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cfe9f42a32
Comment 5 Marco Bonardo [::mak] 2011-12-29 03:34:14 PST
https://hg.mozilla.org/mozilla-central/rev/d1cfe9f42a32

Note You need to log in before you can comment on or make changes to this bug.