Closed Bug 713416 Opened 12 years ago Closed 12 years ago

Remove unnecessary class nsUniCharEntry

Categories

(Core :: Spelling checker, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: khuey, Assigned: santiago.gimeno)

Details

(Whiteboard: [mentor=khuey][lang=c++])

Attachments

(1 file)

Attachment #584325 - Flags: review?(khuey)
Assignee: nobody → santiago.gimeno
Status: NEW → ASSIGNED
Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

Review of attachment 584325 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Ehsan is the owner of this code, so lets get him to approve this change too.

Thanks for the patch!
Attachment #584325 - Flags: review?(khuey)
Attachment #584325 - Flags: review?(ehsan)
Attachment #584325 - Flags: review+
Comment on attachment 584325 [details] [diff] [review]
Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey

This looks great, thanks a lot Santiago!  :-)
Attachment #584325 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/d1cfe9f42a32
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.