Closed
Bug 713416
Opened 12 years ago
Closed 12 years ago
Remove unnecessary class nsUniCharEntry
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: khuey, Assigned: santiago.gimeno)
Details
(Whiteboard: [mentor=khuey][lang=c++])
Attachments
(1 file)
3.29 KB,
patch
|
khuey
:
review+
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/src/mozPersonalDictionary.h#58 is just a duplicate of http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsHashKeys.h#374.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #584325 -
Flags: review?(khuey)
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → santiago.gimeno
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 584325 [details] [diff] [review] Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey Review of attachment 584325 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Ehsan is the owner of this code, so lets get him to approve this change too. Thanks for the patch!
Attachment #584325 -
Flags: review?(khuey)
Attachment #584325 -
Flags: review?(ehsan)
Attachment #584325 -
Flags: review+
Comment 3•12 years ago
|
||
Comment on attachment 584325 [details] [diff] [review] Remove nsUniCharEntry class and replace it with nsUnicharPtrHashKey This looks great, thanks a lot Santiago! :-)
Attachment #584325 -
Flags: review?(ehsan) → review+
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cfe9f42a32
Target Milestone: --- → mozilla12
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d1cfe9f42a32
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•