Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Support JM+TI for architectures without native square root

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: spectre, Assigned: spectre)

Tracking

Trunk
mozilla12
Other
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 584284 [details] [diff] [review]
Keep stub calls for arches w/o FPU sqrt

The currently supported architectures all return true for              masm.supportsFloatingPointSqrt() (except, oddly, MacroAssemblerX86.h which returns m_isSSE2Present). However, FastBuiltins does not use this result anyway; even if the function returns false, it still tries to call masm.sqrtDouble(). Besides older G3 and G4 cores that only have a reciprocal square root estimate instead of a true square root instruction like the G5, there are other embedded cores (PPC or otherwise) that may also lack an FPU square root. This patch forces FastBuiltins.cpp to keep the Math.sqrt stub call if there is no FPU square root available.
(Assignee)

Updated

6 years ago
Attachment #584284 - Flags: review?(dmandelin)
Attachment #584284 - Attachment is patch: true
Attachment #584284 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 1

6 years ago
Thanks for the r+ :)
Assignee: general → spectre
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/c443d73c4346
Keywords: checkin-needed
Target Milestone: --- → mozilla12
Version: 12 Branch → Trunk
https://hg.mozilla.org/mozilla-central/rev/c443d73c4346
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.