As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 713463 - Support JM+TI for architectures without native square root
: Support JM+TI for architectures without native square root
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: Other All
: -- normal (vote)
: mozilla12
Assigned To: Cameron Kaiser [:spectre]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-12-25 11:49 PST by Cameron Kaiser [:spectre]
Modified: 2011-12-30 05:04 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Keep stub calls for arches w/o FPU sqrt (1.91 KB, patch)
2011-12-25 11:49 PST, Cameron Kaiser [:spectre]
dmandelin: review+
Details | Diff | Splinter Review

Description User image Cameron Kaiser [:spectre] 2011-12-25 11:49:30 PST
Created attachment 584284 [details] [diff] [review]
Keep stub calls for arches w/o FPU sqrt

The currently supported architectures all return true for              masm.supportsFloatingPointSqrt() (except, oddly, MacroAssemblerX86.h which returns m_isSSE2Present). However, FastBuiltins does not use this result anyway; even if the function returns false, it still tries to call masm.sqrtDouble(). Besides older G3 and G4 cores that only have a reciprocal square root estimate instead of a true square root instruction like the G5, there are other embedded cores (PPC or otherwise) that may also lack an FPU square root. This patch forces FastBuiltins.cpp to keep the Math.sqrt stub call if there is no FPU square root available.
Comment 1 User image Cameron Kaiser [:spectre] 2011-12-28 12:23:30 PST
Thanks for the r+ :)
Comment 3 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-12-30 05:04:43 PST

Note You need to log in before you can comment on or make changes to this bug.