Closed Bug 713463 Opened 8 years ago Closed 8 years ago

Support JM+TI for architectures without native square root

Categories

(Core :: JavaScript Engine, defect)

Other
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: spectre, Assigned: spectre)

Details

Attachments

(1 file)

The currently supported architectures all return true for              masm.supportsFloatingPointSqrt() (except, oddly, MacroAssemblerX86.h which returns m_isSSE2Present). However, FastBuiltins does not use this result anyway; even if the function returns false, it still tries to call masm.sqrtDouble(). Besides older G3 and G4 cores that only have a reciprocal square root estimate instead of a true square root instruction like the G5, there are other embedded cores (PPC or otherwise) that may also lack an FPU square root. This patch forces FastBuiltins.cpp to keep the Math.sqrt stub call if there is no FPU square root available.
Attachment #584284 - Flags: review?(dmandelin)
Attachment #584284 - Attachment is patch: true
Attachment #584284 - Flags: review?(dmandelin) → review+
Thanks for the r+ :)
Assignee: general → spectre
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/c443d73c4346
Keywords: checkin-needed
Target Milestone: --- → mozilla12
Version: 12 Branch → Trunk
https://hg.mozilla.org/mozilla-central/rev/c443d73c4346
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.