713498 - Allow keyCode and charCode to be different in the temporary mozKeyboard interface

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: patch v.0

Ref: https://github.com/andreasgal/gaia/issues/195

This bug prevents the touch keyboard to function properly - people are unable to test network functionality because they cannot type the "." symbol.

This patch fixes the mozKeyboard interface before the introduction of key events in bug 711486.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 584307 [details] [diff] [review]
patch v.0

>diff -r 9f29daaecbcc b2g/chrome/content/shell.js
> MozKeyboard.prototype = {
>-  sendKey: function mozKeyboardSendKey(keyCode) {
>+  sendKey: function mozKeyboardSendKey(keyCode, charCode) {
>     var utils = window.QueryInterface(Ci.nsIInterfaceRequestor)
>                       .getInterface(Ci.nsIDOMWindowUtils);
>+    if (charCode === undefined) charCode = keyCode;
>     ['keydown', 'keypress', 'keyup'].forEach(function sendKeyEvents(type) {
>-      utils.sendKeyEvent(type, keyCode, keyCode, null);
>+      utils.sendKeyEvent(type, keyCode, charCode, null);

Just do utils.sendKeyEvent(type, keyCode, charCode || keyCode, null);

I will do it while merging.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/507252be27e8

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/507252be27e8