713578 - java.lang.NullPointerException at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

From Socorro : https://crash-stats.mozilla.com/report/index/a4eaa6c8-bae2-4fca-bae5-73e902111226
Build ID : 20111226031002

java.lang.NullPointerException
	at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147)
	at org.mozilla.gecko.Tabs.closeTab(Tabs.java:139)
	at org.mozilla.gecko.TabsTray$TabsAdapter$2.onClick(TabsTray.java:179)
	at android.view.View.performClick(View.java:3117)
	at android.view.View$PerformClick.run(View.java:11941)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:132)
	at org.mozilla.gecko.GeckoApp$33.run(GeckoApp.java:1517)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:132)
	at android.app.ActivityThread.main(ActivityThread.java:4123)
	at java.lang.reflect.Method.invokeNative(Native Method)

On Asus Transformer

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I can't reproduce the crash, but the line seems to suggest "nextTab" is null. We already protect against a null "tab" so this patch adds a check for the "nextTab" too.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/Tabs.java#147

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca8dca9419fc

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 584373 [details] [diff] [review]
patch

crash fix for aurora

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ca8dca9419fc

Comment 5

[LegNeato]

Comment on attachment 584373 [details] [diff] [review]
patch

[triage comment]
Approved for aurora. Mobile only, crash fix, simple null check.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0fa0c1451040