Closed
Bug 713578
Opened 12 years ago
Closed 12 years ago
java.lang.NullPointerException at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox11 fixed, firefox12 fixed)
RESOLVED
FIXED
Firefox 11
People
(Reporter: nhirata, Assigned: mfinkle)
Details
(Keywords: crash, Whiteboard: [native-crash])
Attachments
(1 file)
954 bytes,
patch
|
blassey
:
review+
christian
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
From Socorro : https://crash-stats.mozilla.com/report/index/a4eaa6c8-bae2-4fca-bae5-73e902111226 Build ID : 20111226031002 java.lang.NullPointerException at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147) at org.mozilla.gecko.Tabs.closeTab(Tabs.java:139) at org.mozilla.gecko.TabsTray$TabsAdapter$2.onClick(TabsTray.java:179) at android.view.View.performClick(View.java:3117) at android.view.View$PerformClick.run(View.java:11941) at android.os.Handler.handleCallback(Handler.java:587) at android.os.Handler.dispatchMessage(Handler.java:92) at android.os.Looper.loop(Looper.java:132) at org.mozilla.gecko.GeckoApp$33.run(GeckoApp.java:1517) at android.os.Handler.handleCallback(Handler.java:587) at android.os.Handler.dispatchMessage(Handler.java:92) at android.os.Looper.loop(Looper.java:132) at android.app.ActivityThread.main(ActivityThread.java:4123) at java.lang.reflect.Method.invokeNative(Native Method) On Asus Transformer
Assignee | ||
Comment 1•12 years ago
|
||
I can't reproduce the crash, but the line seems to suggest "nextTab" is null. We already protect against a null "tab" so this patch adds a check for the "nextTab" too. http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/Tabs.java#147
Assignee: nobody → mark.finkle
Attachment #584373 -
Flags: review?(blassey.bugs)
Updated•12 years ago
|
Attachment #584373 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca8dca9419fc
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 584373 [details] [diff] [review] patch crash fix for aurora
Attachment #584373 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 12
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca8dca9419fc
status-firefox11:
--- → affected
status-firefox12:
--- → fixed
Comment on attachment 584373 [details] [diff] [review] patch [triage comment] Approved for aurora. Mobile only, crash fix, simple null check.
Attachment #584373 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/0fa0c1451040
Target Milestone: Firefox 12 → Firefox 11
Version: Firefox 12 → Firefox 11
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•