java.lang.NullPointerException at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147)

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
--
critical
RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: nhirata, Assigned: mfinkle)

Tracking

({crash})

11 Branch
Firefox 11
ARM
Android
crash
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

(Whiteboard: [native-crash])

Attachments

(1 attachment)

From Socorro : https://crash-stats.mozilla.com/report/index/a4eaa6c8-bae2-4fca-bae5-73e902111226
Build ID : 20111226031002

java.lang.NullPointerException
	at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147)
	at org.mozilla.gecko.Tabs.closeTab(Tabs.java:139)
	at org.mozilla.gecko.TabsTray$TabsAdapter$2.onClick(TabsTray.java:179)
	at android.view.View.performClick(View.java:3117)
	at android.view.View$PerformClick.run(View.java:11941)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:132)
	at org.mozilla.gecko.GeckoApp$33.run(GeckoApp.java:1517)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:132)
	at android.app.ActivityThread.main(ActivityThread.java:4123)
	at java.lang.reflect.Method.invokeNative(Native Method)

On Asus Transformer
Created attachment 584373 [details] [diff] [review]
patch

I can't reproduce the crash, but the line seems to suggest "nextTab" is null. We already protect against a null "tab" so this patch adds a check for the "nextTab" too.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/Tabs.java#147
Assignee: nobody → mark.finkle
Attachment #584373 - Flags: review?(blassey.bugs)
Attachment #584373 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca8dca9419fc
Comment on attachment 584373 [details] [diff] [review]
patch

crash fix for aurora
Attachment #584373 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

5 years ago
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/ca8dca9419fc
status-firefox11: --- → affected
status-firefox12: --- → fixed

Comment 5

5 years ago
Comment on attachment 584373 [details] [diff] [review]
patch

[triage comment]
Approved for aurora. Mobile only, crash fix, simple null check.
Attachment #584373 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/0fa0c1451040
status-firefox11: affected → fixed
Target Milestone: Firefox 12 → Firefox 11
Version: Firefox 12 → Firefox 11

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.