Closed Bug 713578 Opened 12 years ago Closed 12 years ago

java.lang.NullPointerException at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147)

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
11 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(firefox11 fixed, firefox12 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 11
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: nhirata, Assigned: mfinkle)

Details

(Keywords: crash, Whiteboard: [native-crash])

Attachments

(1 file)

patch
954 bytes, patch
blassey
: review+
christian
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
From Socorro : https://crash-stats.mozilla.com/report/index/a4eaa6c8-bae2-4fca-bae5-73e902111226
Build ID : 20111226031002

java.lang.NullPointerException
	at org.mozilla.gecko.Tabs.closeTab(Tabs.java:147)
	at org.mozilla.gecko.Tabs.closeTab(Tabs.java:139)
	at org.mozilla.gecko.TabsTray$TabsAdapter$2.onClick(TabsTray.java:179)
	at android.view.View.performClick(View.java:3117)
	at android.view.View$PerformClick.run(View.java:11941)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:132)
	at org.mozilla.gecko.GeckoApp$33.run(GeckoApp.java:1517)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:132)
	at android.app.ActivityThread.main(ActivityThread.java:4123)
	at java.lang.reflect.Method.invokeNative(Native Method)

On Asus Transformer
Attached patch patch — — Splinter Review 
I can't reproduce the crash, but the line seems to suggest "nextTab" is null. We already protect against a null "tab" so this patch adds a check for the "nextTab" too.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/Tabs.java#147
Assignee: nobody → mark.finkle
Attachment #584373 - Flags: review?(blassey.bugs)
Attachment #584373 - Flags: review?(blassey.bugs) → review+
Comment on attachment 584373 [details] [diff] [review]
patch

crash fix for aurora
Attachment #584373 - Flags: approval-mozilla-aurora?
Target Milestone: --- → Firefox 12
Comment on attachment 584373 [details] [diff] [review]
patch

[triage comment]
Approved for aurora. Mobile only, crash fix, simple null check.
Attachment #584373 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/0fa0c1451040
status-firefox11: affected → fixed
Target Milestone: Firefox 12 → Firefox 11
Version: Firefox 12 → Firefox 11
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.