713597 - Crash removing full-screen element during "resize" event

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

The first assertion is like in bug 698340, but the other issues are new.

###!!! ASSERTION: Unnecessary MakeFullScreen call: 'mFullScreen != aFullScreen', file widget/src/cocoa/nsCocoaWindow.mm, line 1163

###!!! ASSERTION: Full-screen element should be the requested element!: 'GetFullScreenElement() == aElement', file content/base/src/nsDocument.cpp, line 8921

###!!! ASSERTION: Should be full-screen doc: 'IsFullScreenDoc()', file content/base/src/nsDocument.cpp, line 8922

Null deref crash [@ nsDocument::RequestFullScreen], but only in debug builds?

Comment 1

[Jesse Ruderman]

Attachment: stack traces

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

This crash only occurs in debug builds. In nsDocument::RequestFullScreen My assertions need to be before the call to SetWindowFullScreen(), as that can run script which cancels full-screen, invalidating the assertions.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch - move assertions

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6928624a1ce

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f6928624a1ce