Crash removing full-screen element during "resize" event

RESOLVED FIXED in mozilla12

Status

()

Core
DOM
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: cpearce)

Tracking

(Blocks: 2 bugs, {assertion, crash, testcase})

Trunk
mozilla12
x86_64
Mac OS X
assertion, crash, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 584371 [details]
testcase

The first assertion is like in bug 698340, but the other issues are new.

###!!! ASSERTION: Unnecessary MakeFullScreen call: 'mFullScreen != aFullScreen', file widget/src/cocoa/nsCocoaWindow.mm, line 1163

###!!! ASSERTION: Full-screen element should be the requested element!: 'GetFullScreenElement() == aElement', file content/base/src/nsDocument.cpp, line 8921

###!!! ASSERTION: Should be full-screen doc: 'IsFullScreenDoc()', file content/base/src/nsDocument.cpp, line 8922

Null deref crash [@ nsDocument::RequestFullScreen], but only in debug builds?
(Reporter)

Comment 1

6 years ago
Created attachment 584372 [details]
stack traces
(Assignee)

Comment 2

6 years ago
This crash only occurs in debug builds. In nsDocument::RequestFullScreen My assertions need to be before the call to SetWindowFullScreen(), as that can run script which cancels full-screen, invalidating the assertions.
(Assignee)

Comment 3

6 years ago
Created attachment 585967 [details] [diff] [review]
Patch - move assertions
Assignee: nobody → chris
Status: NEW → ASSIGNED
Attachment #585967 - Flags: review?(bugs)
Attachment #585967 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6928624a1ce
Target Milestone: --- → mozilla12

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/f6928624a1ce
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.