Last Comment Bug 713597 - Crash removing full-screen element during "resize" event
: Crash removing full-screen element during "resize" event
Status: RESOLVED FIXED
: assertion, crash, testcase
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- critical (vote)
: mozilla12
Assigned To: Chris Pearce (:cpearce)
:
Mentors:
Depends on:
Blocks: 325861 326633
  Show dependency treegraph
 
Reported: 2011-12-26 20:28 PST by Jesse Ruderman
Modified: 2012-01-06 15:57 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (379 bytes, text/html)
2011-12-26 20:28 PST, Jesse Ruderman
no flags Details
stack traces (6.01 KB, text/plain)
2011-12-26 20:28 PST, Jesse Ruderman
no flags Details
Patch - move assertions (2.57 KB, patch)
2012-01-04 19:39 PST, Chris Pearce (:cpearce)
bugs: review+
Details | Diff | Review

Description Jesse Ruderman 2011-12-26 20:28:31 PST
Created attachment 584371 [details]
testcase

The first assertion is like in bug 698340, but the other issues are new.

###!!! ASSERTION: Unnecessary MakeFullScreen call: 'mFullScreen != aFullScreen', file widget/src/cocoa/nsCocoaWindow.mm, line 1163

###!!! ASSERTION: Full-screen element should be the requested element!: 'GetFullScreenElement() == aElement', file content/base/src/nsDocument.cpp, line 8921

###!!! ASSERTION: Should be full-screen doc: 'IsFullScreenDoc()', file content/base/src/nsDocument.cpp, line 8922

Null deref crash [@ nsDocument::RequestFullScreen], but only in debug builds?
Comment 1 Jesse Ruderman 2011-12-26 20:28:46 PST
Created attachment 584372 [details]
stack traces
Comment 2 Chris Pearce (:cpearce) 2012-01-04 19:00:57 PST
This crash only occurs in debug builds. In nsDocument::RequestFullScreen My assertions need to be before the call to SetWindowFullScreen(), as that can run script which cancels full-screen, invalidating the assertions.
Comment 3 Chris Pearce (:cpearce) 2012-01-04 19:39:36 PST
Created attachment 585967 [details] [diff] [review]
Patch - move assertions
Comment 5 Ed Morley [:emorley] 2012-01-06 15:57:40 PST
https://hg.mozilla.org/mozilla-central/rev/f6928624a1ce

Note You need to log in before you can comment on or make changes to this bug.