Closed Bug 713600 Opened 12 years ago Closed 12 years ago

MasterPassword helper is missing _tokenName

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
11 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 fixed, firefox12 fixed)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(1 file)

patch
798 bytes, patch
blassey
: review+
christian
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
We ported most of the JS code from the XUL app, but missed a variable.
Attachment #584384 - Flags: review?(wjohnston)
Attachment #584384 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/04815244051b
Blocks: 700527
status-firefox12: --- → fixed
OS: Linux → Android
Hardware: x86 → All
Target Milestone: --- → Firefox 12
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 584384 [details] [diff] [review]
patch

If bug 700527 is approved for Aurora then this should go with it.
Attachment #584384 - Flags: approval-mozilla-aurora?
Comment on attachment 584384 [details] [diff] [review]
patch

[triage comment]
Approved for aurora. Mobile only, trivial change, helps a parity feature.
Attachment #584384 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a2)Gecko/20120130
Firefox/11.0a2 Fennec/11.0a2
Device: Samsung Galaxy S
OS: Android 2.2
http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/chrome/content/browser.js#3904

Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20120130
Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Galaxy S
OS: Android 2.2
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3950
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.