71361 - Line wrapping in HTML mail within signature lines is disabled

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Katsuhiko Momoi]

** Observed with 3/8/2001 Win32 build **

This seems to be slightly different from Bug 67405
and is filed as a separate bug.

This problem does not happen with plain-text mail editor and so
I've decided to file a new bug for HTML mail editor.

This problem occurs when I have a plain text signature
file automatically appended. So I have a .txt file which
contains lines like:

=========== Beginning of the quoted text ======
-- 
Katsuhiko Momoi
Web Standards/Embedding
Netscape Global Customization Team
[e-mail]
000-000-0000 (Fax)


What is expressed here is my personal opinion and does not reflect jak
official Netscape views.

=========== End of the quoted text ======

Steps to reproduce the problem:

1. Have a .txt signature file which looks like the sample 
   above.
2. Set up your mail account so that it is automatically
   appended to a new message.
3. Bring up HTML mail composer and confirm that the signature
    lines have been quoted.
4. Put the mouse cursor at the beginning of a line
    within the signature block. 
5. Start typing some sentences. You see that the line 
   does not break and the horizontal scroll bar becomes active. 

Notes:

A. This problem does not occur with plain text msgs.
B. This problem may occur if you erase the signature
   lines incompletely and start typing. (I have done this
    by erasing the lines first but leaving behind blank
    lines or blank spaces, which I did not notice.)

Comment 1

[Akkana Peck]

I think the signature is embedded in a <pre>.  Perhaps it should be <pre
cols=$mailwrapcol>, if signature lines are supposed to wrap.  I expect that most
people set up their plaintext signature so that it's already wrapped to a
reasonable line length, so the problem doesn't often arise.

Comment 2

[Katsuhiko Momoi]

I filed this bug mainly as a way to re-produce remainder
of line-wrapping problems mentioned in the other bug.
It is suspicion that we fall into this problem even
when no signatere block exists but somehow find ourselves
in a similar state while editing. 
I just proivided here one specific way the problem occurs.
I hope we can look around to see if we don't fall into 
this non-wrapping mode some other ways. As frustrating
this guess is, I have a feeling that those who keep on
saying there still is a line-wrapping problem is experiencing
some special condition such as the one described here.

Comment 3

[Katsuhiko Momoi]

Here's one scenario of how I fall into this problem.
I have business-oriented signature lines. When I am sending
a personal msg, I delete the entire signature block. About
half of the times, if I delete the sig lines, I experience
this non-wrapping problem. 
I wonder if others delete sig lines like I do. But the
problem occurs often enough under this condition that
it warrants attention.

Comment 4

[Akkana Peck]

I also delete signatures as you describe.  I suspect it's fairly common.

My understanding is that the edit rules are supposed to be able to detect when a
block is empty (e.g. you've deleted the signature, so the enclosing pre is
empty) and delete it as well.  It may be that we're hitting a case where there's
a <br> tag, or something similar, that isn't in the selection when you hit
delete, and the edit rules think that <br> is enough to make the pre nonempty,
and so doesn't delete it.  Considering a br to be nonempty content makes sense
in general, but if that's actually what's happening and there's no easy fix,
perhaps at the end of the document we could special-case that to fix this common
case ...  Joe, would that cause other problems?

Comment 5

[Joe Francis]

see also bug 71345.  i get no wrapping narrow than a certain window width in html 
messages, regardless of sig settings.  also only html mail, not plaintext mail, 
and not html composer.  

Comment 6

[Joe Francis]

akkana, i can't really look at this problem until 71345 is fixed.

Comment 7

[Joe Francis]

marking 0.9.1 so the bean counters won't be awakened. In real life I'll try to 
look at it di=uring moz 0.9.

Comment 8

[varada]

Re-assigning to varada

Comment 9

[varada]

Marking Fixed.

Comment 10

[esther]

Using builds 2001-05-21 on win mac and linux and the original scenario.  I 
had the signature text automatically add when composing a new msg (while in HTML 
editor).  I placed cursor above and typed beyond the set 72 characters, I placed 
the cursor at the beginning of the signature and typed beyond the set 72 
characters, I placed the cursor below the signature and typed beyond the set 72 
charactesrs.  Word wrapped worked.  

I sent the message and clicked Repy (while in HTML editor) again I typed text 
above, below and in front of the signature and word wrapped worked.  Verfified.