Closed Bug 713610 Opened 10 years ago Closed 10 years ago

"ASSERTION: 2nd pass should never guess wrong" in TextOverflow::ExamineLineFrames

Categories

(Core :: Layout: Block and Inline, defect)

Product:
Core
Component:
Layout: Block and Inline
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla12
Tracking Flags:
Tracking Status
firefox9 --- unaffected
firefox10 --- unaffected
firefox11 --- wontfix
firefox12 --- verified

People

(Reporter: jruderman, Assigned: mats)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase, Whiteboard: [qa!])

Attachments

(4 files)

testcase
216 bytes, text/html
Details
stack trace
5.09 KB, text/plain
Details
fix
1.08 KB, patch
roc
: review+
Details | Diff | Splinter Review
regression test
1.04 KB, patch
Details | Diff | Splinter Review
Attached file testcase — 
###!!! ASSERTION: 2nd pass should never guess wrong: 'pass == 0', file /builds/slave/m-cen-osx64-dbg/build/layout/generic/TextOverflow.cpp, line 540

Might be a regression from bug 690187.
Attached file stack trace —
Assignee: nobody → matspal
Severity: normal → trivial
Component: Layout: Text → Layout: Block and Inline
OS: Mac OS X → All
QA Contact: layout.fonts-and-text → layout.block-and-inline
Hardware: x86_64 → All
the try server run https://tbpl.mozilla.org/?tree=Try&rev=cab7d4e1219f
 will not execute the test 
"try: -b do -p all -u reftest -t none"

-u crashtest would do
Thanks Bernd.
Attached patch fix — — Splinter Review 
We should guess 'false' for a side that is inactive.
(the rendering should be correct so there's no need to fix this on Aurora)
Attachment #584552 - Flags: review?(roc)
Attached patch regression test — — Splinter Review
Whiteboard: [qa+]
I'm not able to reproduce the problem. Jesse, is there any chance to remember on what FF did you catch this?
I think it was just a matter of loading the testcase in a debug build of Firefox.
I was able to see the crash on 2011-12-26-mozilla-central-debug build.
Verified fixed on FF 12 2012-04-04-mozilla-beta-debug on Win 7/64, Ubuntu 11.10 and Mac OS X 10.6.
Status: RESOLVED → VERIFIED
status-firefox12: fixed → verified
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.