Closed Bug 713674 Opened 13 years ago Closed 1 year ago

Clang Static Analysis: Branch condition evaluates to a garbage value in lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c

Categories

(NSS :: Libraries, defect, P5)

Product:
NSS
Component:
Libraries
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INACTIVE

People

(Reporter: decoder, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

The following report (in the URL field) has been generated by static analysis using Clang. It would be good if someone familiar with the particular code could check if - this is really a bug or a false positive - and/or if it makes sense to adjust the code (even if there is not a real bug present, e.g. by adding a missing initialization). In this report, Clang seems to believe that the if statements in line 2482 and 2487 can evaluate to different values (can they?). If they can, then I would guess it's due to threading (guessing by the lock statement)? In that case, would the path proposed by Clang be feasible (Race condition)? If they can't, why is repeating the if statements required?
These appear to be the relevant lines: https://hg.mozilla.org/projects/nss/annotate/02928cea0b12/lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c#l2449 https://hg.mozilla.org/projects/nss/annotate/02928cea0b12/lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c#l2454
Assignee: nobody → nobody
Component: Security → Libraries
Product: Core → NSS
Summary: Clang Static Analysis: Branch condition evaluates to a garbage value in security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c → Clang Static Analysis: Branch condition evaluates to a garbage value in lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c
Version: Trunk → trunk
Severity: normal → S3
Severity: S3 → S4
Status: NEW → RESOLVED
Closed: 1 year ago
Priority: -- → P5
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.