713729 - FlingRunnable runs constantly after panning and releasing without flinging

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

While investigating some other bugs, I found a bug in the current FlingRunnable. If you touch down a finger, pan, and then touch up (such that the onTouchEnd happens in state PANNING_HOLD_LOCKED or PANNING_HOLD), this causes the FlingRunnable to continue running forever. This can be seen by sticking a printout in FlingRunnable's run method at the very top and watching logcat.

This appears to be because the mX and mY variables are put into state stopped, but the "flinging with an appreciable velocity" code doesn't take this into account, and bails out of the FlingRunnable too early. Therefore the animation timer never gets stopped and the runnable keeps getting scheduled.

Patch forthcoming.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Don't let the FlingRunnable run forever

Btw, this happens partly because the axes are put into FlingStates.STOPPED if the velocity vector has magnitude < 4.0 (as per stopped()) but in the FlingRunnable.run(), it uses the 0.1f threshold when there's no significant overscroll. This patch just moves that velocity check into the if condition, so that it doesn't run unless a fling is actually in progress.

Comment 2

[Patrick Walton (:pcwalton)]

Comment on attachment 584474 [details] [diff] [review]
Don't let the FlingRunnable run forever

Review of attachment 584474 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Try run showed green: https://tbpl.mozilla.org/?tree=Try&rev=d9f8a97679fa

Landed on m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/bcfe95e5f7bd

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/bcfe95e5f7bd

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 584474 [details] [diff] [review]
Don't let the FlingRunnable run forever

[Triage Comment]
Mobile only - approving for Aurora.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Landed on aurora:

https://hg.mozilla.org/releases/mozilla-aurora/rev/1953793c93e2