Native key iterators should have an array of JSString*

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

unspecified
mozilla12
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently native iterators store an array of jsids when doing a key iteration (for x in y).  When going through the iteration, js_IteratorNext needs to test and convert non-string ids into a string before returning, which happens within a stub call during JM.  It would be simpler if the string conversion happened during construction of the iterator, rendering the test unnecessary.  With some other work, all jitcode tests can be removed from IteratorNext on key iterators, which will simplify and speed things up for IM.
(Assignee)

Comment 1

5 years ago
Created attachment 584496 [details] [diff] [review]
patch (7db218a91c88)
Assignee: general → bhackett1024
Attachment #584496 - Flags: review?(dvander)
Attachment #584496 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/57c19a4e2d50
https://hg.mozilla.org/mozilla-central/rev/57c19a4e2d50
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Depends on: 719686
You need to log in before you can comment on or make changes to this bug.