Closed Bug 713754 Opened 9 years ago Closed 9 years ago

Native key iterators should have an array of JSString*

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

Currently native iterators store an array of jsids when doing a key iteration (for x in y).  When going through the iteration, js_IteratorNext needs to test and convert non-string ids into a string before returning, which happens within a stub call during JM.  It would be simpler if the string conversion happened during construction of the iterator, rendering the test unnecessary.  With some other work, all jitcode tests can be removed from IteratorNext on key iterators, which will simplify and speed things up for IM.
Assignee: general → bhackett1024
Attachment #584496 - Flags: review?(dvander)
Attachment #584496 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/57c19a4e2d50
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Depends on: 719686
You need to log in before you can comment on or make changes to this bug.