Closed
Bug 713754
Opened 13 years ago
Closed 13 years ago
Native key iterators should have an array of JSString*
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
14.20 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Currently native iterators store an array of jsids when doing a key iteration (for x in y). When going through the iteration, js_IteratorNext needs to test and convert non-string ids into a string before returning, which happens within a stub call during JM. It would be simpler if the string conversion happened during construction of the iterator, rendering the test unnecessary. With some other work, all jitcode tests can be removed from IteratorNext on key iterators, which will simplify and speed things up for IM.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: general → bhackett1024
Attachment #584496 -
Flags: review?(dvander)
|
||
Updated•13 years ago
|
Attachment #584496 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/57c19a4e2d50
|
||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57c19a4e2d50
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•