Closed Bug 713759 Opened 8 years ago Closed 8 years ago

Split PNK_INC and PNK_DEC into pre- and post- variants, rather than depending on an op for this

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
More simplicity in differentiating parse nodes.
Attachment #584489 - Flags: review?(bhackett1024)
Comment on attachment 584489 [details] [diff] [review]
Patch

Review of attachment 584489 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsreflect.cpp
@@ -2429,3 @@
>        {
> -        bool incr = pn->isKind(PNK_INC);
> -        bool prefix = pn->getOp() >= JSOP_INCNAME && pn->getOp() <= JSOP_DECELEM;

Gross, nice to kill this.
Attachment #584489 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/f2cefd34dcd0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.