Last Comment Bug 713759 - Split PNK_INC and PNK_DEC into pre- and post- variants, rather than depending on an op for this
: Split PNK_INC and PNK_DEC into pre- and post- variants, rather than depending...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-27 14:36 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-12-29 03:17 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (5.38 KB, patch)
2011-12-27 14:36 PST, Jeff Walden [:Waldo] (remove +bmo to email)
bhackett1024: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-27 14:36:26 PST
Created attachment 584489 [details] [diff] [review]
Patch

More simplicity in differentiating parse nodes.
Comment 1 Brian Hackett (:bhackett) 2011-12-27 15:31:48 PST
Comment on attachment 584489 [details] [diff] [review]
Patch

Review of attachment 584489 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsreflect.cpp
@@ -2429,3 @@
>        {
> -        bool incr = pn->isKind(PNK_INC);
> -        bool prefix = pn->getOp() >= JSOP_INCNAME && pn->getOp() <= JSOP_DECELEM;

Gross, nice to kill this.
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-29 00:59:57 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2cefd34dcd0
Comment 3 Marco Bonardo [::mak] 2011-12-29 03:17:52 PST
https://hg.mozilla.org/mozilla-central/rev/f2cefd34dcd0

Note You need to log in before you can comment on or make changes to this bug.