Split PNK_INC and PNK_DEC into pre- and post- variants, rather than depending on an op for this

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 584489 [details] [diff] [review]
Patch

More simplicity in differentiating parse nodes.
Attachment #584489 - Flags: review?(bhackett1024)
Comment on attachment 584489 [details] [diff] [review]
Patch

Review of attachment 584489 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsreflect.cpp
@@ -2429,3 @@
>        {
> -        bool incr = pn->isKind(PNK_INC);
> -        bool prefix = pn->getOp() >= JSOP_INCNAME && pn->getOp() <= JSOP_DECELEM;

Gross, nice to kill this.
Attachment #584489 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2cefd34dcd0
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/f2cefd34dcd0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.