713811 - Aurora/Nightly icon misplaced when opening a .dmg

Status: REOPENED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Screenshot

This happens on current nightlies. See attached screenshot.

I'm using Lion, if that makes a difference.

Comment 1

[Mike Hommey [:glandium]]

In fact, this is apparently limited to Aurora and Nightly:
- Nightly 12.0a1 is broken
- Aurora 11.0a2 is broken
- Beta 10.0b1 is ok
And the most interesting part:
- Aurora 10.0a2 is broken

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

Attachment: Namoroka 3.6.27pre

For the record, this also appears to affect the Firefox 3.6 nightlies (Namoroka).

Comment 3

[Mike Hommey [:glandium]]

Looks like current builds are fine.

Comment 4

[Gordon P. Hemsley [:GPHemsley]]

I just had this happen on a try build I made (which had the name 'FirefoxNightlyDebug'), though I can confirm that it doesn't seem to happen in a real nightly.

This does still happen on the latest ESR nightly, however. The Nomoroka (3.6.29pre) nightly does not have the fancy background at all, and the Applications shortcut is to the left of the built app.

On the basis of the ESR and custom builds, I'm going to reopen this.

Comment 5

[Yurii Kolesnykov]

I think we should close this.

Comment 6

[Molly Howell (she/her) (mostly inactive)]

No longer reproduces even on my local build.

Comment 7

[Mike Hommey [:glandium]]

FWIW, I've seen this fairly recently, from a try build iirc. Can you check that?

Comment 8

[Molly Howell (she/her) (mostly inactive)]

I grabbed the DMG out of a very recent try push [0], and I don't see anything wrong (except for bug 1183833 because I have hidden files showing).

[0] https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b4322e848dd03067fb272044db28dd6495df68fe&selectedJob=126852142

Comment 9

[Mike Hommey [:glandium]]

I've just seen it on an autoland build from just now:
https://queue.taskcluster.net/v1/task/N7zQ3r9bRT6hvmV64i3E9A/runs/0/artifacts/public/build/target.dmg
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0e349b74bfc6e12a3e7177a908484e0418a01725&selectedJob=131186183

Comment 10

[Mike Hommey [:glandium]]

And it's not happening on the opt build, so this might actually be related to naming.

Comment 11

[Molly Howell (she/her) (mostly inactive)]

Yes, I do see that.

This isn't really my area, but my guess is that you're right and the problem is that the pre-baked .DS_Store file has an icon location entry for FirefoxNightly.app (the app bundle name for opt builds), but not for NightlyDebug.app (the app bundle name for debug builds).