crash in nsMsgDatabase::SetSummaryValid if feed db out of date

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
Database
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

({regression})

Trunk
Thunderbird 12.0
x86_64
Windows 7
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

779 bytes, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 584578 [details] [diff] [review]
proposed fix

If a feed database is out of date, we crash trying to download new messages in nsMsgDatabase::SetSummaryValid() because of a null m_dbFolderInfo.

I checked prior to the pluggable store landing and we checked for a null m_dbFolderInfo.
Attachment #584578 - Flags: review?(neil)

Comment 1

5 years ago
Comment on attachment 584578 [details] [diff] [review]
proposed fix

Well, nsMailDatabase::SetSummaryValid certainly null-checks m_dbFolderInfo... nsMsgDatabase::SetSummaryValid never used to, but presumably we're passing it true which it used to ignore completely.
Attachment #584578 - Flags: review?(neil) → review+
(Assignee)

Comment 2

5 years ago
fixed on trunk http://hg.mozilla.org/comm-central/rev/349840cd946a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: regression
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Blocks: 402392
No longer depends on: 402392
You need to log in before you can comment on or make changes to this bug.