Don't allow user to use empty password for master password

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: tchung, Assigned: wesj)

Tracking

Trunk
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 verified, fennec11+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We need to add some inline messaging when a new master password textboxes are empty.  User can currently hit OK with blank entries, and nothing happens.

Repro:
1) fennec nightly, 12-28-2011 build, SGS2
2) launch prefs, check the Use master password button
3) When the dialog box appears with the password / confirm password textboxes, leave it blank and hit OK.   Alternately, skipping the password box, and just typing in confirmation does the same
4) verify no inline messages or action required to the user.  

Expected:
- an inline message telling the user to fill out both boxes.  also disabling OK if there's no entries.

Actual;
- no messaging
Changing to "Don't allow user to tap 'OK' if the password fields are blank"
Assignee: nobody → wjohnston
Priority: -- → P3
Summary: Need inline error messaging when skipping master password entries → Don't allow user to use empty password for master password
(Assignee)

Comment 2

5 years ago
Created attachment 586520 [details] [diff] [review]
Patch
Attachment #586520 - Flags: review?(mark.finkle)
Comment on attachment 586520 [details] [diff] [review]
Patch

Make sure you test this by adding, removing and re-adding a master password. Just to make sure the dialogs work in cyclical usage.
Attachment #586520 - Flags: review?(mark.finkle) → review+
tracking-fennec: --- → 11+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/19af1aac33ac
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Comment on attachment 586520 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): landing of mp on trunk
User impact if declined: Very low. Users will be able to attempt to use an empty mp. it will fail
Testing completed (on m-c, etc.): on m-c for a bit now
Risk to taking this patch (and alternatives if risky): very low risk
Attachment #586520 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
Comment on attachment 586520 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #586520 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/8508d6cc7e46
status-firefox11: --- → fixed
status-firefox12: --- → fixed

Comment 8

5 years ago
Verified fixed on:
Nightly Fennec 13.0a1 (2012-03-06)
Device: HTC Desire Z
OS: Android 2.3.3

The OK button is not active until the two fields: password and confirm password are not identical and different of null.
Status: RESOLVED → VERIFIED
status-firefox13: --- → verified

Updated

5 years ago
Duplicate of this bug: 733754
You need to log in before you can comment on or make changes to this bug.