713922 - Don't allow user to use empty password for master password

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Tony Chung [:tchung]]

We need to add some inline messaging when a new master password textboxes are empty.  User can currently hit OK with blank entries, and nothing happens.

Repro:
1) fennec nightly, 12-28-2011 build, SGS2
2) launch prefs, check the Use master password button
3) When the dialog box appears with the password / confirm password textboxes, leave it blank and hit OK.   Alternately, skipping the password box, and just typing in confirmation does the same
4) verify no inline messages or action required to the user.  

Expected:
- an inline message telling the user to fill out both boxes.  also disabling OK if there's no entries.

Actual;
- no messaging

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Changing to "Don't allow user to tap 'OK' if the password fields are blank"

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 586520 [details] [diff] [review]
Patch

Make sure you test this by adding, removing and re-adding a master password. Just to make sure the dialogs work in cyclical usage.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/mozilla-central/rev/19af1aac33ac

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 586520 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): landing of mp on trunk
User impact if declined: Very low. Users will be able to attempt to use an empty mp. it will fail
Testing completed (on m-c, etc.): on m-c for a bit now
Risk to taking this patch (and alternatives if risky): very low risk

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 586520 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8508d6cc7e46

Comment 8

[Paul Feher]

Verified fixed on:
Nightly Fennec 13.0a1 (2012-03-06)
Device: HTC Desire Z
OS: Android 2.3.3

The OK button is not active until the two fields: password and confirm password are not identical and different of null.