Closed Bug 714029 Opened 8 years ago Closed 8 years ago

Avoid jsctypes-test dependency on the xpcom glue

Categories

(Core :: js-ctypes, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12
Tracking Status
firefox11 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

The jsctypes-test uses NS_strlen, which is in the xpcom glue. It links against the standalone glue for that. For purpose of bug 683127 testing, the xpcom standalone glue is modified to use wrapped calls to dlopen and related functions in the part that initializes xpcom dynamically. However, due to linker stupidity, despite that part being dead code, and despite the linker not including it in the library, it still wants to resolve the dlopen and related wrappers, and thus fails to link.
Since jsctypes-test only uses NS_strlen, it's actually pretty straightforward to just get rid of the whole dependency.
Assignee: nobody → mh+mozilla
See comment 0 for the stupid reasons why this is needed. Since I was adding a simple implementation of NS_strlen, I implemented it as a template and replaced plain strlen as well.
Attachment #584717 - Flags: review?(benjamin)
Attachment #584717 - Flags: review?(benjamin) → review+
Backed out, it broke windows. Looks like a missing mozalloc on the link command line.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2447177ec5a
Whiteboard: [inbound]
Relanded with a fixup to keep MOZALLOC_LIB in EXTRA_DSO_LDOPTS
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9aeacb404ba
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
[Approval Request Comment]
This is a dependency of bug 683127. It changes how the js-ctypes test library is linked (removes the dependency on the xpcom glue and library dependencies it doesn't need)
Attachment #591495 - Flags: review+
Attachment #591495 - Flags: approval-mozilla-aurora?
Attachment #591495 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.