Avoid jsctypes-test dependency on the xpcom glue

RESOLVED FIXED in Firefox 11

Status

()

Core
js-ctypes
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla12
All
Linux
Points:
---

Firefox Tracking Flags

(firefox11 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
The jsctypes-test uses NS_strlen, which is in the xpcom glue. It links against the standalone glue for that. For purpose of bug 683127 testing, the xpcom standalone glue is modified to use wrapped calls to dlopen and related functions in the part that initializes xpcom dynamically. However, due to linker stupidity, despite that part being dead code, and despite the linker not including it in the library, it still wants to resolve the dlopen and related wrappers, and thus fails to link.
Since jsctypes-test only uses NS_strlen, it's actually pretty straightforward to just get rid of the whole dependency.
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 1

6 years ago
Created attachment 584717 [details] [diff] [review]
Avoid jsctypes-test dependency on the xpcom glue

See comment 0 for the stupid reasons why this is needed. Since I was adding a simple implementation of NS_strlen, I implemented it as a template and replaced plain strlen as well.
Attachment #584717 - Flags: review?(benjamin)
Attachment #584717 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/057e7ead186e
Whiteboard: [inbound]
(Assignee)

Comment 3

5 years ago
Backed out, it broke windows. Looks like a missing mozalloc on the link command line.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2447177ec5a
Whiteboard: [inbound]
(Assignee)

Comment 4

5 years ago
Relanded with a fixup to keep MOZALLOC_LIB in EXTRA_DSO_LDOPTS
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9aeacb404ba

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e9aeacb404ba
Target Milestone: --- → mozilla12
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

5 years ago
Created attachment 591495 [details] [diff] [review]
Avoid jsctypes-test dependency on the xpcom glue - for aurora

[Approval Request Comment]
This is a dependency of bug 683127. It changes how the js-ctypes test library is linked (removes the dependency on the xpcom glue and library dependencies it doesn't need)
Attachment #591495 - Flags: review+
Attachment #591495 - Flags: approval-mozilla-aurora?
Attachment #591495 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/d8158788ac4d
status-firefox11: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.