714131 - [ICS] Implement the new clipboard bar in the actionbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Steps:
1. Load a website
2. Tap on URLbar to open the awesomescreen
3. long tap on the selected text (the current URL should be selected)

The menu that is displayed acts like no text is selected in the textbox. If you pick "Select All", then long tap again and you'll see "Cut" and "Copy" on the menu.

Comment 1

[Martijn Wargers (dead)]

I don't get a context menu at all in current nightly build, I'm only getting the selection tool.

Comment 2

[Aaron Train [:aaronmt]]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #1)
> I don't get a context menu at all in current nightly build, I'm only getting
> the selection tool.

Ditto. Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20111230 Firefox/12.0a1 Fennec/12.0a1

Comment 3

[Aaron Train [:aaronmt]]

Basic feature which is annoying to not have. Recommended P2.

Comment 4

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2afd7ae68e8b&tochange=4e4878620bb5

Could be bug 708616, bug 711905, bug 708700 just guessing

CC'ing Wes and Sriram.

Comment 5

[Aaron Train [:aaronmt]]

Work around is to switch to landscape keyboard. Also can't select input method without a context menu.

Comment 6

[Aaron Train [:aaronmt]]

Apparently this is broken on ICS.

This works on a recent inbound build on Gingerbread on my Galaxy SII.

Comment 7

[Chris Lord [:cwiiis]]

Also recommending at least P2 - not being able to copy/paste links from other apps/the stock browser into fennec can be quite limiting.

Comment 8

[Sriram Ramasubramanian [:sriram]]

In ICS, we might need to add an ActionMode to perform this. Currently we are overriding the ActionBar with our custom ActionBar.

Comment 9

[Sriram Ramasubramanian [:sriram]]

On my further investigation, the edit-text boxes in "ActionBar" have "android:textIsSelectable" to be false. http://developer.android.com/reference/android/widget/TextView.html#attr_android:textIsSelectable [I verified this from logs].

Hence, a new ActionMode would not appear by default. (This happens if the edit-text was available inside the content).

I checked apps like People (Contacts app in ICS). The Search box on the ActionBar doesn't allow text selection and pasting.

Since ICS doesn't have the ability to have "context menu" on "long press", this feature cannot be triggered by any means.

Only way to have the cut, copy, paste is for us to manually have an ActionMode and use it.

The stock browser does this differently. To my knowledge, they have their own custom ActionBar. On long press, the contents of the ActionBar is "overlaid" on top of actual screen and shown, and the actual ActionBar moves into an ActionMode showing the icons. Things to note here:
1. The ActionMode for Stock browser (note the "Share" icon to share the URL) uses a custom one. The background color is different as well.
2. The URL bar is either in ActionBar or as part of main layout -- which I couldn't confirm properly. The menu button is confusing me. But Android IRC channel confirmed that they use a custom menu button.

If we want edit options, we need to do an ActionMode for our own use.

Comment 11

[Sriram Ramasubramanian [:sriram]]

If we show an ActionMode for these actions, we need to move the ActionBar (currently showing AwesomeBar) to main layout. Is this the desired approach?

Comment 12

[Aaron Train [:aaronmt]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #11)
> If we show an ActionMode for these actions, we need to move the ActionBar
> (currently showing AwesomeBar) to main layout. Is this the desired approach?

Performance hit?

Comment 13

[Sriram Ramasubramanian [:sriram]]

Playing with ActionMode for some time, I found this.
On starting ActionMode on long-press, we need to move the contents of the ActionBar to a temporary View on top of the tabs. The new ActionMode pops up now. However, the text in the EditText (the awesomebar-search) is not selectable! Also, the ActionMode exists from there when I press on the EditText or even when I take my finger from the old EditText.
I am unable to fix this part.

The other option is to show a "context-menu" with the options. Even then, the select wouldn't be selectable as long as EditText is in ActionBar. This is a known issue in all EditTexts in ICS. e.g. People app.

Comment 14

[Wesley Johnston (:wesj)]

Can we play with putting the tabs on top (in the ActionBar) here, and hiding them (the tabs) if the user focuses/starts editing the textbox? That seems more IceCreamSandwichy to me anyway.

Comment 15

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch brings back the default ActionMode.
The ActionBar for AwesomeBar is now removed. This patch adds a small little menu button in Galaxy Nexus.

Also, this doesn't address the landscape mode of AwesomeBar -- which wouldn't be needed as the keyboard comes up in landscape mode.

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #15)
> Created attachment 605008 [details] [diff] [review]
> Patch
> 
> This patch brings back the default ActionMode.
> The ActionBar for AwesomeBar is now removed. This patch adds a small little
> menu button in Galaxy Nexus.

We need a way to remove this menu button. How does Chrome and Stock do it?

> Also, this doesn't address the landscape mode of AwesomeBar -- which
> wouldn't be needed as the keyboard comes up in landscape mode.

We are actually working to not use the landscape keyboard. This might not be an issue for long. What impact does it have currently?

Comment 17

[Sriram Ramasubramanian [:sriram]]

The impact in landscape mode is not big. Instead of 42dip height, we will be showing 48dip for AwesomeBar.

Comment 18

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch avoids the menu button and hides the action-bar in XML (just like TabsTray) -- hence no performance regression. When we long press on the awesomebar-search, the default action-mode kicks in.

Comment 19

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f5b002584ce3

Comment 20

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/f5b002584ce3

Comment 21

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 15.0a1 (2012-05-21)
Device: Galaxy Nexus
OS: Android 4.0.2