714132 - Possible double release of a NSColor

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Hubert Figuiere [:hub]]

in nsCocoaWindow.mm around line 2318
in the method -[ToolbarWindow initWithContentRect:...], we do mBackgroundColor = [NSColor whiteColor]. but in the dealloc, we do [mBackgroundColor release] which leads so do we in -[ToolbarWindow setBackgroundColor:].

[NSColor whiteColor] returns an "autoreleased", therefor we should retain it.

The fact that it does not crash is surprising, albeit maybe not as it is entirely possible that the framework returns a static instance. But this is implementation dependent.

Will attach a patch.

Comment 1

[Hubert Figuiere [:hub]]

Attachment: [NSColor whiteColor] must be retained in ToolbarWindow. r=

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 584805 [details] [diff] [review]
[NSColor whiteColor] must be retained in ToolbarWindow. r=

I also don't know why we don't crash, but this is the right thing to do.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 584805 [details] [diff] [review]
[NSColor whiteColor] must be retained in ToolbarWindow. r=

Landed on mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0022f8be9fea

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0022f8be9fea