Closed Bug 714140 Opened 8 years ago Closed 8 years ago

Charlton Company trademark notice can be removed from About dialog

Categories

(Firefox :: General, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: liz, Assigned: Dolske)

Details

Attachments

(3 files)

Our obligation to include a trademark attribution for Charlton Company expired on November 23, 2011. The notice can be removed from all future versions of Firefox.
Attached patch Patch v.1Splinter Review
Essentially undoing gavin's patch from bug 616193.

The CSS for .trademark-label isn't needed, because the theme already twiddles things for #trademark. I'll attach a screenshot after my build finishes.
Assignee: nobody → dolske
Attachment #584881 - Flags: review?(gavin.sharp)
Attached image Screenshot
Looks good to me.
I'm a little concerned about the trolololo section, and would ask that the following mod be considered. :) (I keed, I keed, but couldn't resist)

Also, hooray for this bug! \o/

(In reply to Justin Dolske [:Dolske] from comment #2)
> Created attachment 584890 [details]
> Screenshot
Attachment #584881 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/b7dd715e6009
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Liz: just in case you're wondering, this change will be in Firefox 12. According to the release calendar (https://wiki.mozilla.org/RapidRelease/Calendar), that will be shipped as a stable version to all our users on 4/24 (or available as a beta on 3/13). [Well, the _actual_ ship dates are a few days later to allow to testing and such.]
thanks
You need to log in before you can comment on or make changes to this bug.