Closed Bug 714148 Opened 10 years ago Closed 10 years ago

NullPointerException at org.mozilla.gecko.db.AndroidBrowserDB.updateFaviconForUrl

Categories

(Firefox for Android Graveyard :: General, defect, P1)

ARM
Android
defect

Tracking

(firefox11 fixed, fennec11+)

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: gcp, Assigned: gcp)

Details

Attachments

(1 file)

E/AndroidRuntime(15451): FATAL EXCEPTION: Thread-14
E/AndroidRuntime(15451): java.lang.NullPointerException
E/AndroidRuntime(15451): 	at org.mozilla.gecko.db.AndroidBrowserDB.updateFaviconForUrl(AndroidBrowserDB.java:273)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.db.BrowserDB.updateFaviconForUrl(BrowserDB.java:140)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.addFavicon(ProfileMigrator.java:276)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migrateFavicons(ProfileMigrator.java:302)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migratePlaces(ProfileMigrator.java:345)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.run(ProfileMigrator.java:377)
E/AndroidRuntime(15451): 	at java.lang.Thread.run(Thread.java:1020)
BitmapDrawable image = (BitmapDrawable) Drawable.createFromStream(byteStream, "src");

Using the result of this is wrapped in a try/catch but it doesn't handle the NPE. Want to add some logging to see what image is failing anyway.
Assignee: nobody → gpascutto
Priority: -- → P1
If Android can't decode the stored favicon because the data is truncated or in a format it can't handle, just skip it.
Attachment #584879 - Flags: review?(mark.finkle)
Attachment #584879 - Flags: approval-mozilla-aurora?
Comment on attachment 584879 [details] [diff] [review]
Patch 1. Check for incomplete/undecodable images

Simple fix, we should take for aurora
Attachment #584879 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/aaf31de64891
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 584879 [details] [diff] [review]
Patch 1. Check for incomplete/undecodable images

[Triage Comment]
Mobile only - approving for Aurora.
Attachment #584879 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.