Expose CPP from configure to the build system

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

(Blocks: 1 bug)

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I don't think mozilla-central needs this, but the InstantBird folks do, and it's easy enough to do.
Blocks: 596002
Created attachment 584852 [details] [diff] [review]
Patch
Attachment #584852 - Flags: review?(ted.mielczarek)

Comment 2

5 years ago
Yes we do need this. I just tried this patch on our win32 slave and here what we found out :
$(CPP) works well with gmake, it's an implicit variable replaced at use time by '$(CC) -E'.

When I call 'make showbuild' on a gmake objdir, I have this line : '/path/to/python.exe -O /path/to/mozilla/build/cl.py cl -E'
whie, using this patch, with pymake, I have the following value : 'cl -E -nologo'.

Using this value should work in our test case, but I'm not sure the result is what is expected. I believe we should find a patch on pymake. I tried to add 'CPP': '$(CC) -E', in pymake/implicit.py but it seems that '$(CC)' is resolved at init time rather that at use time (CPP = ' -E' when doing a showbuild).

Hope this helps a little...
Comment on attachment 584852 [details] [diff] [review]
Patch

Review of attachment 584852 [details] [diff] [review]:
-----------------------------------------------------------------

The inconsistent spacing in this file drives me nuts, but it's not worth worrying about.
Attachment #584852 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/projects/build-system/rev/c56d11e05feb
Is using 'cl -E -nologo' instead of '/path/to/python.exe -O /path/to/mozilla/build/cl.py cl -E' (as mentioned in comment 2) something that should worry us?
Probably not.  cl.py is only used for dependency generation for future rebuilds.
https://hg.mozilla.org/mozilla-central/rev/c56d11e05feb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.