Last Comment Bug 714205 - IonMonkey: Merge some framePushed changes to x86
: IonMonkey: Merge some framePushed changes to x86
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Nicolas B. Pierron [:nbp]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-29 17:25 PST by Marty Rosenberg [:mjrosenb]
Modified: 2012-01-11 02:18 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove ifdef from callVM. (9.95 KB, patch)
2012-01-10 14:53 PST, Nicolas B. Pierron [:nbp]
cdleary: review+
Details | Diff | Splinter Review

Description Marty Rosenberg [:mjrosenb] 2011-12-29 17:25:35 PST
In bug bug 713915, I made some useful changes to arm which should be reflected on x86/64.
This will enable us to remove some #if defined(JS_CPU_ARM)
Comment 1 Nicolas B. Pierron [:nbp] 2012-01-10 14:53:05 PST
Created attachment 587489 [details] [diff] [review]
Remove ifdef from callVM.
Comment 2 Chris Leary [:cdleary] (not checking bugmail) 2012-01-10 21:03:31 PST
Comment on attachment 587489 [details] [diff] [review]
Remove ifdef from callVM.

Review of attachment 587489 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

::: js/src/ion/shared/MacroAssembler-x86-shared.h
@@ +168,5 @@
>          movl(Operand(address), dest);
>      }
>      void callWithExitFrame(IonCode *target) {
>          uint32 descriptor = MakeFrameDescriptor(framePushed(), IonFrame_JS);
> +        Push(Imm32(descriptor));

Yay, unbroken!

Note You need to log in before you can comment on or make changes to this bug.