Closed
Bug 714205
Opened 12 years ago
Closed 12 years ago
IonMonkey: Merge some framePushed changes to x86
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mjrosenb, Assigned: nbp)
Details
Attachments
(1 file)
9.95 KB,
patch
|
cdleary
:
review+
|
Details | Diff | Splinter Review |
In bug bug 713915, I made some useful changes to arm which should be reflected on x86/64. This will enable us to remove some #if defined(JS_CPU_ARM)
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: general → nicolas.b.pierron
Status: NEW → ASSIGNED
Attachment #587489 -
Flags: review?(sstangl)
Assignee | ||
Updated•12 years ago
|
Attachment #587489 -
Flags: review?(sstangl) → review?(christopher.leary)
Comment 2•12 years ago
|
||
Comment on attachment 587489 [details] [diff] [review] Remove ifdef from callVM. Review of attachment 587489 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch. ::: js/src/ion/shared/MacroAssembler-x86-shared.h @@ +168,5 @@ > movl(Operand(address), dest); > } > void callWithExitFrame(IonCode *target) { > uint32 descriptor = MakeFrameDescriptor(framePushed(), IonFrame_JS); > + Push(Imm32(descriptor)); Yay, unbroken!
Attachment #587489 -
Flags: review?(christopher.leary) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/32da87962f94 https://hg.mozilla.org/projects/ionmonkey/rev/524b705fe740 (fix)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•